From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9660 invoked by alias); 10 May 2012 14:39:44 -0000 Received: (qmail 9427 invoked by uid 22791); 10 May 2012 14:39:43 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 May 2012 14:39:16 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4AEdFuY021071 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 10 May 2012 10:39:15 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4AEdDXl031507 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 10 May 2012 10:39:14 -0400 From: Tom Tromey To: Kaushik Phatak Cc: "gdb-patches\@sourceware.org" , "Jayant R. Sonar" , Prafulla Thakare Subject: Re: [Patch] CR16 Simulator fix for gdb 7.4 References: Date: Thu, 10 May 2012 14:39:00 -0000 In-Reply-To: (Kaushik Phatak's message of "Thu, 10 May 2012 14:23:14 +0000") Message-ID: <87sjf8p0by.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00344.txt.bz2 >>>>> "Kaushik" == Kaushik Phatak writes: Kaushik> I am not able to figure out the reason why the attached hunk Kaushik> (nltvals.def) has been removed from the sources, maybe Kaushik> regenerate missed it out. I don't think this patch is ok as-is. The top of nltvals.def says: /* This file is machine generated by gennltvals.sh. */ So, I think the bug must either be in gennltvals.sh, or in one of its input files, and the proper way to fix this would be to find the original bug, fix it, and re-run gennltvals.sh. Tom