From: Tom Tromey <tromey@redhat.com>
To: Stan Shebs <stanshebs@earthlink.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Logging for MI
Date: Wed, 27 Jun 2012 19:40:00 -0000 [thread overview]
Message-ID: <87sjdg5ysf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4FE80E5E.903@earthlink.net> (Stan Shebs's message of "Mon, 25 Jun 2012 00:08:14 -0700")
>>>>> "Stan" == Stan Shebs <stanshebs@earthlink.net> writes:
Stan> Although the patch seems straightforward, it entailed quite a bit of
Stan> trial-and-error, and I've probably missed a few cases in the tangled
Stan> tubing that is GDB's ui-file system; comments welcome.
I don't really understand all that code either.
It is pretty light on docs; but also just convoluted.
Stan> I plan to commit this in a few days if no flaws come to light.
I was curious whether it did the right thing if logging is enabled and
then the user sends a CLI command to the MI interpreter.
I dug through the code a little but couldn't convince myself either way.
Tom
next prev parent reply other threads:[~2012-06-27 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 7:09 Stan Shebs
2012-06-26 16:18 ` Eli Zaretskii
2012-06-27 19:40 ` Tom Tromey [this message]
2012-06-27 22:24 ` Stan Shebs
2012-06-28 3:14 ` Yao Qi
2012-06-28 22:15 ` Stan Shebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjdg5ysf.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=stanshebs@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox