From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21869 invoked by alias); 4 Nov 2013 16:24:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21839 invoked by uid 89); 4 Nov 2013 16:24:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Nov 2013 16:24:40 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA4GOWwm017712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 4 Nov 2013 11:24:32 -0500 Received: from barimba (ovpn-113-94.phx2.redhat.com [10.3.113.94]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rA4GOUos020581 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 4 Nov 2013 11:24:31 -0500 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 2/4] Perf test framework References: <1383291300-13917-1-git-send-email-yao@codesourcery.com> <1383291300-13917-3-git-send-email-yao@codesourcery.com> <877gcryhnz.fsf@fleche.redhat.com> <52746636.8080102@codesourcery.com> Date: Mon, 04 Nov 2013 16:27:00 -0000 In-Reply-To: <52746636.8080102@codesourcery.com> (Yao Qi's message of "Sat, 2 Nov 2013 10:40:54 +0800") Message-ID: <87sivcuoch.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00061.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> * lib/perftest.exp: New. Yao> * gdb.perf/lib/perftest/__init__.py: New. Yao> * gdb.perf/lib/perftest/measure.py: New. Yao> * gdb.perf/lib/perftest/perftest.py: New. Yao> * gdb.perf/lib/perftest/reporter.py: New. Yao> * gdb.perf/lib/perftest/testresult.py: New. Thanks for making that change, Yao. One more little nit: Yao> + if { "$GDB_PERFTEST_MODE" != "compile" Yao> + && "$GDB_PERFTEST_MODE" != "run" Yao> + && "$GDB_PERFTEST_MODE" != "both" } { Yao> + # GDB_PERFTEST_MODE=compile|run|both is allowed. Yao> + unsupported "Unknown value of GDB_PERFTEST_MODE." Yao> + return 1 This is basically an internal error. Calling "error" and having a backtrace in the log seems better to me. Tom