From: Tom Tromey <tromey@redhat.com>
To: "Tedeschi\, Walfred" <walfred.tedeschi@intel.com>
Cc: Pedro Alves <palves@redhat.com>, Yao Qi <yao@codesourcery.com>,
"Mark Kettenis \(mark.kettenis\@xs4all.nl\)"
<mark.kettenis@xs4all.nl>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [pushed] [PATCH V7 0/8] Intel(R) MPX register support
Date: Fri, 22 Nov 2013 17:23:00 -0000 [thread overview]
Message-ID: <87siuocq7e.fsf@fleche.redhat.com> (raw)
In-Reply-To: <AC542571535E904D8E8ADAE745D60B191B1D9C3D@IRSMSX104.ger.corp.intel.com> (Walfred Tedeschi's message of "Fri, 22 Nov 2013 12:32:45 +0000")
>>>>> ">" == Tedeschi, Walfred <walfred.tedeschi@intel.com> writes:
>> BTW: Next patch we will squash i386/amd64/gdbserver. Should this three
>> patches also be send for review as a single commit?
Usually it's best to make each patch work independently. This is the
ideal because then one doesn't need to do anything special when
submitting or merging.
Of course, it isn't always possible. Sometimes a patch is easier to
read when split, but the split means that some sub-patch doesn't build.
In this case I think it is fine to note the issue in the email and then
remember to squash the relevant patches at merge time.
Tom
next prev parent reply other threads:[~2013-11-22 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 13:11 Tedeschi, Walfred
2013-11-21 20:48 ` Pedro Alves
2013-11-22 8:41 ` Tedeschi, Walfred
2013-11-22 12:50 ` Tedeschi, Walfred
2013-11-22 13:41 ` Yao Qi
2013-11-22 13:51 ` Pedro Alves
2013-11-22 13:57 ` Tedeschi, Walfred
2013-11-22 14:31 ` Tedeschi, Walfred
2013-11-22 17:23 ` Tom Tromey [this message]
[not found] ` <AC542571535E904D8E8ADAE745D60B191B1DACC6@IRSMSX104.ger.corp.intel.com>
2013-11-25 12:24 ` FYI: gdbserver crash due to: " Joel Brobecker
2013-11-25 12:51 ` Tedeschi, Walfred
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siuocq7e.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=palves@redhat.com \
--cc=walfred.tedeschi@intel.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox