From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22142 invoked by alias); 27 Nov 2013 17:23:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22121 invoked by uid 89); 27 Nov 2013 17:23:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_20,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2013 17:23:00 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rARHMoNx011953 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Nov 2013 12:22:50 -0500 Received: from barimba (ovpn-113-124.phx2.redhat.com [10.3.113.124]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rARHMn4q026649 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 27 Nov 2013 12:22:49 -0500 From: Tom Tromey To: Marcus Shawcroft Cc: Sergio Durigan Junior , Marcus Shawcroft , GDB Patches Subject: Re: [PATCH] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64 References: <1385336092-19621-1-git-send-email-sergiodj@redhat.com> <52931DB7.6030205@arm.com> Date: Wed, 27 Nov 2013 17:52:00 -0000 In-Reply-To: (Marcus Shawcroft's message of "Tue, 26 Nov 2013 09:46:13 +0000") Message-ID: <87siuh21zr.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00850.txt.bz2 >>>>> "Marcus" == Marcus Shawcroft writes: Marcus> Sorry, I was not clear. I think the a64 and a32 parsers should be kept Marcus> separate rather than using a common parser for a different, but Marcus> similar syntax, thus avoiding the need to pass the flag that Marcus> distinguishes the different syntaxes. It seems reasonable to me. It looks to me like the current function arm_stap_parse_special_token is the only code shared by the patch. That isn't so long by itself, and then if it needs tweaks for AArch64 -- one might as well just copy it. Tom