From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-110224-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3004 invoked by alias); 10 Feb 2014 17:50:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 2842 invoked by uid 89); 10 Feb 2014 17:50:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Feb 2014 17:50:24 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1AHoKqN028469	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 10 Feb 2014 12:50:20 -0500
Received: from barimba (ovpn-113-148.phx2.redhat.com [10.3.113.148])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s1AHoJtu012847	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 10 Feb 2014 12:50:20 -0500
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFC v2 07/38] Add target_ops argument to to_close
References: <1391720136-2121-1-git-send-email-tromey@redhat.com>	<1391720136-2121-8-git-send-email-tromey@redhat.com>	<52F59D5B.2040308@codesourcery.com>
Date: Mon, 10 Feb 2014 17:50:00 -0000
In-Reply-To: <52F59D5B.2040308@codesourcery.com> (Yao Qi's message of "Sat, 8	Feb 2014 10:58:35 +0800")
Message-ID: <87sirqyi09.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2014-02/txt/msg00323.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> /* Fetch the AT_HWCAP entry from the aux vector.  */
Yao> static unsigned long
Yao> ppc_linux_get_hwcap (void)
Yao> {
Yao>   CORE_ADDR field;

Yao>   if (target_auxv_search (&current_target, AT_HWCAP, &field))
Yao>     return (unsigned long) field;

Yao>   return 0;
Yao> }

Yao> Do we need to add argument 'ops' to ppc_linux_get_hwcap and stop
Yao> using current_target in ppc_linux_get_hwcap?

It depends on whether the call should act at the current stratum or
below, or whether the call should restart from the top of the target
stack.

In most cases I think the latter is intended.

Yao> You may have done that in the following patches, and it is not
Yao> surprise I miss it.

Nope.

Tom