From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26995 invoked by alias); 21 Oct 2014 08:13:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26986 invoked by uid 89); 21 Oct 2014 08:13:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Oct 2014 08:13:55 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1XgUZk-0007Ce-GF from Yao_Qi@mentor.com ; Tue, 21 Oct 2014 01:13:52 -0700 Received: from GreenOnly (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.181.6; Tue, 21 Oct 2014 01:13:51 -0700 From: Yao Qi To: Victor Kamensky CC: Subject: Re: [PATCH 3/5] ARM: arm_breakpoint should be little endian form in case for arm BE8 References: <1413853021-4393-1-git-send-email-victor.kamensky@linaro.org> <1413853021-4393-4-git-send-email-victor.kamensky@linaro.org> Date: Tue, 21 Oct 2014 08:13:00 -0000 In-Reply-To: <1413853021-4393-4-git-send-email-victor.kamensky@linaro.org> (Victor Kamensky's message of "Mon, 20 Oct 2014 17:56:59 -0700") Message-ID: <87siihj12g.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00537.txt.bz2 Victor Kamensky writes: > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 2aef5dc..c32fb3f 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,5 +1,10 @@ > 2014-10-13 Victor Kamensky >=20=20 > + * arm-tdep.c: (extract_arm_insn): use dbarch_byte_order_for_code > + to read arm instruction. The file and function name in the changelog entry is wrong. The description of each entry is a sentence, so the first letter should be capitalized. * arm-linux-tdep.c (arm_linux_init_abi): Use gdbarch_byte_order_for_code to read arm instruction. Otherwise, it looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)