Re: [PATCH v5 4/5] Include group information to xml syscall files.

Gabriel Krisman Bertazi
2016-05-20T02:30:36Z

[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]

Hey Doug,

> At the moment all group information comes from the defaults (I think).
> I'm assuming all one has to do for special cases is add the group(s)
> directly to the foo-xml.in file and that will work. Right?

Yes, it will (partially) work, but there is a limitation there. You can
add groups for specific architectures directly in the <arch>.xml.in
file, but we don't allow appending more groups if there are some already
defined for that syscall in the linux-defaults file. In other words,
appending more groups for a given syscall is not supported. I didn't
see a need for that when I wrote it a while ago.

But this is a limitation, so I fixed that up in v6, which I'll post
soon after this email.

> IWBN to have some examples so people don't work from a default modus
> operandi
> of adding everything to linux-defaults.xml.in.

I didn't see the need nor have a good example for that now.. Do you have
a suggestion? Shouldn't we enforce it during review?

> btw, why is linux-defaults.xml.in a ".in" file?
> I'd expect it to just be linux-defaults.xml.

Because it won't be used directly, but serve as input to the xsl
pre-processor.

--
Gabriel Krisman Bertazi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]