Re: [PATCH v6 3/5] Add tests for catching groups of syscalls on supported architectures.

Sergio Durigan Junior
2016-05-26T18:18:07Z

On Thursday, May 19 2016, Gabriel Krisman Bertazi wrote:

> gdb/testsuite/
>
> * gdb.base/catch-syscall.exp (do_syscall_tests): Add call
> to test_catch_syscall_group.
> (test_catch_syscall_group): New.

Thanks for the patch.

> ---
> gdb/testsuite/gdb.base/catch-syscall.exp | 39 ++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.base/catch-syscall.exp b/gdb/testsuite/gdb.base/catch-syscall.exp
> index 5679000..e55bd70 100644
> --- a/gdb/testsuite/gdb.base/catch-syscall.exp
> +++ b/gdb/testsuite/gdb.base/catch-syscall.exp
> @@ -370,6 +370,42 @@ proc test_catch_syscall_fail_nodatadir {} {
> }
> }
>
> +proc test_catch_syscall_group {} {
> + global decimal
> +
> + set sysnum "\\\[${decimal}\\\]"
> +
> + gdb_test "catch syscall g:process" \
> + "Catchpoint $decimal \\(syscalls (\'(clone|fork|execve|exit)\' $sysnum)+.*" \
> + "set catchpoint on a group of syscalls"
> +
> + gdb_test "catch syscall group:process read" \
> + "Catchpoint $decimal \\(syscalls (\'(clone|fork|execve|exit)\' $sysnum)+.*read.*\\)" \
> + "set catchpoints on a group of syscalls and on a single syscall"
> +
> + gdb_test "catch syscall group:" \
> + "Unknown syscall group ''\." \
> + "set catchpoints on an invalid group"
> +
> + gdb_test "catch syscall g:junk" \
> + "Unknown syscall group 'junk'\." \
> + "set catchpoints on an unknown group."
> +
> + gdb_test "complete catch syscall g:proc" \
> + "catch syscall g:process" \
> + "complete catch syscall group with 'g:' prefix"
> +
> + gdb_test "complete catch syscall group:proc" \
> + "catch syscall group:process" \
> + "complete catch syscall group with 'group:' prefix"
> +
> + gdb_test_sequence "complete catch syscall g" \
> + "complete catch syscall group suggests 'group:' prefix" {
> + "group:descriptor" "group:file" "group:ipc" "group:memory"
> + "group:network" "group:process" "group:signal"
> + }
> +}
> +
> proc do_syscall_tests {} {
> # NOTE: We don't have to point gdb at the correct data-directory.
> # For the build tree that is handled by INTERNAL_GDBFLAGS.
> @@ -420,6 +456,9 @@ proc do_syscall_tests {} {
> # Testing if the 'catch syscall' command works when switching to
> # different architectures on-the-fly (PR gdb/10737).
> if [runto_main] then { test_catch_syscall_multi_arch }
> +
> + # Testing the 'catch' syscall command for a group of syscalls.
> + if [runto_main] then { test_catch_syscall_group }
> }
>
> proc test_catch_syscall_without_args_noxml {} {
> --
> 2.4.11

LGTM.

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible