From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57241 invoked by alias); 20 May 2016 02:30:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56447 invoked by uid 89); 20 May 2016 02:30:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 spammy=hey X-HELO: layla.krisman.be Received: from layla.krisman.be (HELO layla.krisman.be) (176.31.208.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 20 May 2016 02:30:24 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (envelope-from ) id 1b3Zlx-0002KS-Ag; Fri, 20 May 2016 04:02:42 +0200 From: Gabriel Krisman Bertazi To: Doug Evans Cc: gdb-patches@sourceware.org, palves@redhat.com, sergiodj@redhat.com Subject: Re: [PATCH v5 4/5] Include group information to xml syscall files. References: <047d7b111fe189726f05330d0fb0@google.com> Date: Fri, 20 May 2016 02:30:00 -0000 In-Reply-To: <047d7b111fe189726f05330d0fb0@google.com> (Doug Evans's message of "Tue, 17 May 2016 17:27:51 +0000") Message-ID: <87shxd1mx2.fsf@oberon.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00346.txt.bz2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 1182 Hey Doug, > At the moment all group information comes from the defaults (I think). > I'm assuming all one has to do for special cases is add the group(s) > directly to the foo-xml.in file and that will work. Right? Yes, it will (partially) work, but there is a limitation there. You can add groups for specific architectures directly in the .xml.in file, but we don't allow appending more groups if there are some already defined for that syscall in the linux-defaults file. In other words, appending more groups for a given syscall is not supported. I didn't see a need for that when I wrote it a while ago. But this is a limitation, so I fixed that up in v6, which I'll post soon after this email. > IWBN to have some examples so people don't work from a default modus > operandi > of adding everything to linux-defaults.xml.in. I didn't see the need nor have a good example for that now.. Do you have a suggestion? Shouldn't we enforce it during review? > btw, why is linux-defaults.xml.in a ".in" file? > I'd expect it to just be linux-defaults.xml. Because it won't be used directly, but serve as input to the xsl pre-processor. --=20 Gabriel Krisman Bertazi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 818 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXPna5AAoJEO9pqxSS5VgPK/IQAJoi9D2HkoXO+dW0h5eaONIA snJTkyu2VmHhlOAqtt01Q2jdG3zS+vbX1oQEiwAeJSDfqFr6DdJxnS+IeMcg18se Od0ELjgOYZZ91/E0FkWzAm7JW8sxtT/HUxiHn/2jhP2MrbJzsjwEVW27cs2QIi4q H9PyTYk3T/elsyfQddFxuOy/HWFmyoJ5SI66ruQ0filAceLEXLD8Fw0N7Yaqr5zt Cu/U2syZp6cdN4EutZb8aVUBGYm2ZeJ0uwyREt2rF1pZZc0ZX7lkqOJ62YoYM/6x J/jbxbBAdfDukGdhuIaIKyrt4NONf39ZoVEN1wt+iGFwVVzBK/xCCvBaTegckMA2 UX4Y+51UoCnbu6PIsN9+rfctq5ZCgQfe46vW0v3a/UtNY9vaIvUXAWJ9akd/qQHh C5V1C5aPbiV4oL/OumB4x5bGGj8rNPB2Qc72HWm5DArPv1Fof7nGlVzIUYeJWsgU 5Gtdamwxo0MvMt8qlDfEPYFoGcL1h83imSyvxB4X50sdxKUxZMYuYyJV8RMPYd/q k4HsqL9XKc8rkn9IkqbIbV8V7O6ufiIY5ya4ZtCHXxqbhTHUe0VRCWB8LMV/cPUR ndXK3B93TZWn6eBxszfBroajhri8F4QVP5bob7xmRKAXfST1sTOHzMktX4lyT0Cb CqTSCc6Vq0kfaqVAo+vo =d0Qf -----END PGP SIGNATURE----- --=-=-=--