From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63645 invoked by alias); 8 Jun 2016 02:46:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63636 invoked by uid 89); 8 Jun 2016 02:46:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=sticking X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 08 Jun 2016 02:46:46 +0000 Received: (qmail 2115 invoked by uid 0); 8 Jun 2016 02:46:42 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy5.mail.unifiedlayer.com with SMTP; 8 Jun 2016 02:46:42 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id 42md1t00d2f2jeq012mgdS; Tue, 07 Jun 2016 20:46:40 -0600 X-Authority-Analysis: v=2.1 cv=OPe0g0qB c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=-N9Dh3nx2ZYA:10 a=pD_ry4oyNxEA:10 a=V82Az2P4AAAA:8 a=5VctFVOvtUIdivb762AA:9 a=GUYa6fla-me-Zpd7-Uj-:22 Received: from [65.128.48.199] (port=49908 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1bATVu-00011Z-PQ; Tue, 07 Jun 2016 20:46:38 -0600 From: Tom Tromey To: Trevor Saunders Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 6/6] Add -Wunused-but-set-* to build References: <1465248812-23902-1-git-send-email-tom@tromey.com> <1465248812-23902-7-git-send-email-tom@tromey.com> <20160608023751.GC30231@ball> Date: Wed, 08 Jun 2016 02:46:00 -0000 In-Reply-To: <20160608023751.GC30231@ball> (Trevor Saunders's message of "Tue, 7 Jun 2016 22:37:51 -0400") Message-ID: <87shwo5rec.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 65.128.48.199 authed with tom+tromey.com} X-Exim-ID: 1bATVu-00011Z-PQ X-Source-Sender: (bapiya) [65.128.48.199]:49908 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-06/txt/msg00148.txt.bz2 >>>>> "Trevor" == Trevor Saunders writes: Trevor> isn't everything in -Wunused enabled now? can we just delete Trevor> -Wno-unused and use -Wall to get us -Wunused? I didn't think of that -- thanks. From the gcc docs I see -Wunused-label, -Wunused-local-typedefs, and -Wunused-parameter. That final one seems difficult for gdb given the many functions that are called via function pointers but which do not use all their arguments. Once the switch to C++ is complete, such parameters could be nameless. To me that seems better than sticking ATTRIBUTE_UNUSED in many places. Tom