From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71956 invoked by alias); 30 Sep 2016 15:44:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71938 invoked by uid 89); 30 Sep 2016 15:44:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=cleanups X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Fri, 30 Sep 2016 15:44:03 +0000 Received: (qmail 32560 invoked by uid 0); 30 Sep 2016 15:44:02 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy6.mail.unifiedlayer.com with SMTP; 30 Sep 2016 15:44:02 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id prjz1t00B2f2jeq01rk2Gx; Fri, 30 Sep 2016 09:44:02 -0600 X-Authority-Analysis: v=2.1 cv=ffo+lSgF c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=GW1xBdLrtEIA:10 a=zstS-IiYAAAA:8 a=FeU7vBIb2LCsuVqsM0EA:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:36926 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bpzyg-0005jp-V1; Fri, 30 Sep 2016 09:43:59 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 13/22] Remove unnecessary cleanup from stabsread.c References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-14-git-send-email-tom@tromey.com> Date: Fri, 30 Sep 2016 16:19:00 -0000 In-Reply-To: <1474949330-4307-14-git-send-email-tom@tromey.com> (Tom Tromey's message of "Mon, 26 Sep 2016 22:08:41 -0600") Message-ID: <87shshfl4y.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bpzyg-0005jp-V1 X-Source-Sender: 71-218-192-86.hlrn.qwest.net (bapiya) [71.218.192.86]:36926 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-09/txt/msg00434.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> This removes an unnecessary cleanup from stabsread.c. It's Tom> unnecessary because nothing between the cleanup creation and use makes Tom> a cleanup. I think this turns out to be incorrect, because read_struct_type calls some functions that leave dangling cleanups. So, I'm dropping this patch from the series. Tom