From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18203 invoked by alias); 30 Sep 2016 14:43:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18143 invoked by uid 89); 30 Sep 2016 14:43:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=yours, super X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Fri, 30 Sep 2016 14:43:19 +0000 Received: (qmail 30541 invoked by uid 0); 30 Sep 2016 14:43:17 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy6.mail.unifiedlayer.com with SMTP; 30 Sep 2016 14:43:17 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id pqjB1t01T2f2jeq01qjESp; Fri, 30 Sep 2016 08:43:15 -0600 X-Authority-Analysis: v=2.1 cv=NphCLatJ c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=GW1xBdLrtEIA:10 a=20KFwNOVAAAA:8 a=neo7SEWSmfg3Jg7mkcoA:9 a=GQ3Bw1r201u2VzAt:21 a=ltg_1N_eyIRB7TzB:21 a=e_O65bzb51kRm2y5VmPK:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:44428 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bpyTg-0004O3-V5; Fri, 30 Sep 2016 08:07:53 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 19/22] Convert tid_range_parser to class References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-20-git-send-email-tom@tromey.com> <55f2924c-f8f9-6c06-ffbb-69079b6ffa62@redhat.com> Date: Fri, 30 Sep 2016 14:52:00 -0000 In-Reply-To: <55f2924c-f8f9-6c06-ffbb-69079b6ffa62@redhat.com> (Pedro Alves's message of "Fri, 30 Sep 2016 02:40:34 +0100") Message-ID: <87shsha3bf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bpyTg-0004O3-V5 X-Source-Sender: 71-218-192-86.hlrn.qwest.net (pokyo) [71.218.192.86]:44428 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-09/txt/msg00430.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Whoops, we ended up duplicating work here. Oops :) But no big deal. Pedro> Additional differences compared to yours are: Pedro> - "bool" instead of "int". Pedro> - "m_" prefixes. Aha, the m_ prefix. Cancel that earlier question... Pedro> Let me know what you think. It's super fine with me to rebase Pedro> mine on top of yours. Did you have a follow up patch for Pedro> get_number_or_range too, perhaps? I don't. How about I just drop my patch? That seems simplest to me. Pedro> void Pedro> -init_number_or_range (struct get_number_or_range_state *state, Pedro> - const char *string) Pedro> +number_or_range_parser::init (const char *string) Pedro> { Pedro> - memset (state, 0, sizeof (*state)); Pedro> - state->string = string; Pedro> + memset (this, 0, sizeof (*this)); I think it's better to do explicit initialization. This will bite if this class ever is changed to have a vtable (unlikely but it's better, IMO, to set a good example). Tom