From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120418 invoked by alias); 4 Oct 2016 18:52:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120396 invoked by uid 89); 4 Oct 2016 18:52:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy1.mail.unifiedlayer.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO gproxy1.mail.unifiedlayer.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Oct 2016 18:52:41 +0000 Received: from cmgw4 (cmgw5 [10.0.90.85]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id 9D166178545 for ; Tue, 4 Oct 2016 12:49:05 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id rWp11t00n2f2jeq01Wp4uG; Tue, 04 Oct 2016 12:49:05 -0600 X-Authority-Analysis: v=2.1 cv=XeEakuJ5 c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=20KFwNOVAAAA:8 a=734gTNrQgrFVyCZOkbwA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:42130 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1brUlx-0005OE-Ci; Tue, 04 Oct 2016 12:49:01 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 1/3] PR symtab/20652 - fix psymbol_compare References: <1475531646-18049-1-git-send-email-tom@tromey.com> <1475531646-18049-2-git-send-email-tom@tromey.com> Date: Tue, 04 Oct 2016 18:52:00 -0000 In-Reply-To: (Pedro Alves's message of "Tue, 4 Oct 2016 19:37:14 +0100") Message-ID: <87shsc7xwl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1brUlx-0005OE-Ci X-Source-Sender: 71-218-192-86.hlrn.qwest.net (pokyo) [71.218.192.86]:42130 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00065.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I wonder whether using memcpy is really the correct thing Pedro> here, considering ginfo.value is a union. I.e., thinking about Pedro> padding bits not part of the active member. Maybe we're zero Pedro> initializing the whole value and it works in practice because Pedro> of that. Yes, psymbols are fully zero-initialized so that they can be entered into the bcache. See add_psymbol_to_bcache. Tom