Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch+7.12.1 2/2] Fix TLS (such as 'errno') regression
Date: Mon, 10 Oct 2016 14:50:00 -0000	[thread overview]
Message-ID: <87shs4xnpd.fsf@tromey.com> (raw)
In-Reply-To: <20161009185647.GB13645@host1.jankratochvil.net> (Jan	Kratochvil's message of "Sun, 9 Oct 2016 20:56:47 +0200")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> For the testcase it is important the variable is in objfile with non-zero base
Jan> address.

My only question about this patch is why the symbol's section has a
non-zero section offset.  Is that the reason why?

Maybe it would make sense to make a SEC_THREAD_LOCAL section always have
a zero offset.  Then touching all the users wouldn't be necessary.

On the third hand it seems strange to even try to get the "address" of a
TLS symbol in this way.

Tom


  parent reply	other threads:[~2016-10-10 14:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-09 18:57 Jan Kratochvil
2016-10-10 10:45 ` Mark Wielaard
2016-10-10 14:50 ` Tom Tromey [this message]
2016-10-10 15:13   ` Jan Kratochvil
2016-10-10 22:43     ` Tom Tromey
2017-09-06 11:58 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shs4xnpd.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox