From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125687 invoked by alias); 19 May 2017 09:44:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125674 invoked by uid 89); 19 May 2017 09:44:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 spammy=Hx-languages-length:818, vladimir X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 May 2017 09:44:41 +0000 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v4J9igw1031000 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 19 May 2017 09:44:42 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v4J9ifAg006532 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 May 2017 09:44:42 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id v4J9id5O032044 for ; Fri, 19 May 2017 09:44:40 GMT Received: from termi.oracle.com (/10.175.210.85) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 19 May 2017 02:44:38 -0700 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: vladimir.mezentsev@oracle.com Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb passes and returns incorrect values when dealing with small array on Sparc References: <1494950959-42849-1-git-send-email-vladimir.mezentsev@oracle.com> Date: Fri, 19 May 2017 09:44:00 -0000 In-Reply-To: <1494950959-42849-1-git-send-email-vladimir.mezentsev@oracle.com> (vladimir mezentsev's message of "Tue, 16 May 2017 11:09:19 -0500") Message-ID: <87shk1mb99.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00429.txt.bz2 From: Vladimir Mezentsev gdb has a special type (TYPE_CODE_ARRAY) to support the gcc extension (https://gcc.gnu.org/onlinedocs/gcc/Vector-Extensions.html). TYPE_CODE_ARRAY is handled incorrectly for both (32- and 64-bit) modes on Sparc machines. Tested on sparc64-linux-gnu and sparc-solaris (32- and 64-bit mode). No regressions. gdb/ChangeLog: 2017-05-12 Vladimir Mezentsev * sparc-tdep.c (sparc_structure_return_p) (sparc_arg_on_registers_p): New functions. (sparc32_store_arguments): Use them. * sparc64-tdep.c (sparc64_16_byte_align_p) (sparc64_store_floating_fields, sparc64_extract_floating_fields): Handle TYPE_CODE_ARRAY. LGTM. Ok for master?