From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124615 invoked by alias); 7 Jun 2017 21:01:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124597 invoked by uid 89); 7 Jun 2017 21:01:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-15.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1710 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Jun 2017 21:01:41 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 85D4E80474 for ; Wed, 7 Jun 2017 21:01:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 85D4E80474 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 85D4E80474 Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A7E217A7B; Wed, 7 Jun 2017 21:01:44 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH v6 3/4] Share fork_inferior et al with gdbserver References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <20170504052954.16936-1-sergiodj@redhat.com> <20170504052954.16936-4-sergiodj@redhat.com> <0e95d746-9293-3301-15ed-84d6c4280116@redhat.com> <87poep8zdg.fsf@redhat.com> Date: Wed, 07 Jun 2017 21:01:00 -0000 In-Reply-To: (Pedro Alves's message of "Wed, 7 Jun 2017 13:23:33 +0100") Message-ID: <87shjbo6ko.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00178.txt.bz2 On Wednesday, June 07 2017, Pedro Alves wrote: > On 06/07/2017 11:15 AM, Pedro Alves wrote: >> On 05/31/2017 04:43 AM, Sergio Durigan Junior wrote: >>> >>>>>>> index 4ea7913..8aa85db 100644 >>>>>>> --- a/gdb/gdbserver/configure.ac >>>>>>> +++ b/gdb/gdbserver/configure.ac >>>>>>> @@ -462,7 +462,9 @@ esac], >>>>>>> >>>>>>> if $want_ipa ; then >>>>>>> if $have_ipa ; then >>>>>>> - IPA_DEPFILES="$ipa_obj" >>>>>>> + # Needed because safe_strerror's definition is host-dependent >>>>> >>>>> Why do we end up needing safe_strerror in the IPA in the first place? >>> This is needed because I moved the definition of >>> trace_start_error_with_name from the old gdb/fork-child.c to >>> common/common-utils.c. This function which uses safe_strerror, and >>> common/common-utils.c is compiled by IPA. >>> >>> An option would be to keep these trace_start_error.* functions in >>> nat/fork-inferior.c, but I think it is more logical to keep them on >>> common-utils.c. >> >> I'd rather not add them to the IPA. The least unnecessary code >> is included in that library the better, because it is injected >> into the target process. So keeping them in fork-inferior.c >> sounds better. >> > > I tried it against v7, and that works. The think to keep > in mind is that these trace_start_error functions > are only called from the fork child, so they're very much > fork-inferior.c related. They're actually being used by some -nat.c files on gdb/, and -low.c files on gdbserver. But as I said, I'm OK with your suggestion. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/