From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29394 invoked by alias); 10 May 2018 18:34:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29382 invoked by uid 89); 10 May 2018 18:34:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 May 2018 18:34:43 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1E9FB7C6B3; Thu, 10 May 2018 18:34:42 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0078B63F2E; Thu, 10 May 2018 18:34:41 +0000 (UTC) From: Sergio Durigan Junior To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA] inadvertent language switch during breakpoint_re_set_one References: <1525976353-67414-1-git-send-email-brobecker@adacore.com> Date: Thu, 10 May 2018 18:58:00 -0000 In-Reply-To: <1525976353-67414-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Thu, 10 May 2018 14:19:13 -0400") Message-ID: <87sh6zxsu6.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00247.txt.bz2 On Thursday, May 10 2018, Joel Brobecker wrote: > Hello, Hey Joel, [...] > diff --git a/gdb/language.h b/gdb/language.h > index 029de4a..3e2b90a 100644 > --- a/gdb/language.h > +++ b/gdb/language.h > @@ -705,4 +705,30 @@ private: > enum language m_lang; > }; > > +/* Save the current language mode and restore it upon destruction. */ > + > +class scoped_restore_current_language_mode > +{ > +public: > + > + explicit scoped_restore_current_language_mode () > + : m_lang_mode (language_mode) > + { > + } > + > + ~scoped_restore_current_language_mode () > + { > + language_mode = m_lang_mode; > + } > + > + scoped_restore_current_language_mode > + (const scoped_restore_current_language_mode &) = delete; > + scoped_restore_current_language_mode &operator= > + (const scoped_restore_current_language_mode &) = delete; I think you can use DISABLE_COPY_AND_ASSIGN here. Cheers, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/