From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110676 invoked by alias); 16 May 2018 20:53:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110661 invoked by uid 89); 16 May 2018 20:53:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 May 2018 20:53:47 +0000 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4GKigUr124241 for ; Wed, 16 May 2018 16:53:45 -0400 Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153]) by mx0b-001b2d01.pphosted.com with ESMTP id 2j0ubnhre7-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 16 May 2018 16:53:45 -0400 Received: from localhost by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 16 May 2018 14:53:45 -0600 Received: from b03cxnp08026.gho.boulder.ibm.com (9.17.130.18) by e35.co.us.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 16 May 2018 14:53:44 -0600 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4GKrgBk11796752; Wed, 16 May 2018 13:53:42 -0700 Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B303C78038; Wed, 16 May 2018 14:53:42 -0600 (MDT) Received: from pedro.localdomain (unknown [9.18.235.221]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP id 7BC2478043; Wed, 16 May 2018 14:53:42 -0600 (MDT) Received: by pedro.localdomain (Postfix, from userid 1000) id 24F7E3C03C6; Wed, 16 May 2018 17:53:40 -0300 (-03) From: Pedro Franco de Carvalho To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 8/8] [PowerPC] Recognize isa205 in linux core files In-Reply-To: <20180516155030.9DA61D802CA@oc3748833570.ibm.com> References: <20180516155030.9DA61D802CA@oc3748833570.ibm.com> Date: Wed, 16 May 2018 23:32:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 18051620-0012-0000-0000-000016401FD3 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009036; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000260; SDB=6.01033290; UDB=6.00528327; IPR=6.00812422; MB=3.00021150; MTD=3.00000008; XFM=3.00000015; UTC=2018-05-16 20:53:44 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18051620-0013-0000-0000-000052CC1338 Message-Id: <87sh6ruxt7.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-16_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805160204 X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00367.txt.bz2 Ulrich Weigand writes: > Maybe this routine should now be moved to ppc-linux-tdep.c ... > >> + CORE_ADDR hwcap = 0; >> + >> + target_auxv_search (target, AT_HWCAP, &hwcap); >> + >> + features.isa205 = ppc_linux_has_isa205 (hwcap); > > ... so it can be reused here? > > Otherwise this looks OK to me. Should the routine take a struct target_ops * parameter, so that core_read_description can pass its target (for calling target_auxv_search)? In this case all the calls in ppc_linux_nat.c would also have to be updated. Thanks! Pedro