Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [OB PATCH][gdb/testsuite] Make noclone conditional in vla-optimized-out.c
Date: Wed, 25 Jul 2018 19:19:00 -0000	[thread overview]
Message-ID: <87sh47yvho.fsf@tromey.com> (raw)
In-Reply-To: <20180720150532.e7dvwtbzyysqwcld@delia> (Tom de Vries's message	of "Fri, 20 Jul 2018 17:05:32 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Hi,
Tom> Make the noclone attribute on f1 in vla-optimized-out.c conditional.  This
Tom> makes the test-case by default identical to
Tom> gcc/testsuite/gcc.dg/guality/vla-1.c.

Tom> Tested on x86_64-linux.

Tom> OK for trunk?

I think this was included in a different patch of yours?
Anyway, it is ok, thank you.

It seems like it would be good to mention the GCC file in one of these
files.  If you want to add a comment to that effect, it is pre-approved.

Tom


  reply	other threads:[~2018-07-25 19:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 15:05 Tom de Vries
2018-07-25 19:19 ` Tom Tromey [this message]
2018-07-26  8:33   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sh47yvho.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox