From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109974 invoked by alias); 3 Aug 2018 18:29:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109964 invoked by uid 89); 3 Aug 2018 18:28:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_RP_RNBL,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=approve, clearing, HX-HELO:sk:gateway, HX-Local-Domain:yes X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.149.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Aug 2018 18:28:58 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id E496C184405 for ; Fri, 3 Aug 2018 13:28:56 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id leoqfFwahPvAdleoqfI2q0; Fri, 03 Aug 2018 13:28:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=za12qgm7otgzE2xv3bJQjsiBCzs78NzAt47z4VKZLxk=; b=oBA4yEddalKV4GDstu2x/sVS8J OvYM8jI6yosy8QnZ89ZEIpjYwL6sYc7F9W/xkSXNNw2eIyrlM0at1jDA2OvkSmjHe5AiJ5gF98UOw Zc/O73jAbi44PXiAOf8pJA+6Z; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:35330 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fleoq-001fIj-N9; Fri, 03 Aug 2018 13:28:56 -0500 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/2] Fix regressions for multi breakpoints command line setting/clearing References: <20180802212613.29813-1-philippe.waroquiers@skynet.be> <20180802212613.29813-2-philippe.waroquiers@skynet.be> Date: Fri, 03 Aug 2018 18:29:00 -0000 In-Reply-To: <20180802212613.29813-2-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Thu, 2 Aug 2018 23:26:12 +0200") Message-ID: <87sh3v1ezc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00066.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> Note that such problem could also (or should?) be fixed by reworking Philippe> the way read_command_lines manages the memory of input lines, so as Philippe> to solve this globally, and not at all places where possibly a Philippe> 'being handled' line of input might be re-allocated. Philippe> Tom is looking at this, but in the meantime, Philippe> this patch just goes back to the previous way to avoid the Philippe> error (and be able to have the regression tests for the Philippe> functional regression working). Yeah, I'd rather do the deeper fix, because otherwise we will have an API that's difficult to use correctly. But if I can't get it finished soon, I'll approve this. Tom