From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126429 invoked by alias); 30 Aug 2018 15:06:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126417 invoked by uid 89); 30 Aug 2018 15:06:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.60.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Aug 2018 15:06:51 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway20.websitewelcome.com (Postfix) with ESMTP id E3E36400F02F8 for ; Thu, 30 Aug 2018 10:06:49 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vOWQfl0JybXuJvOWnf690r; Thu, 30 Aug 2018 10:06:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uRkPyLiauBqOhaNbaytpihZtsDuMWoNN74ZEnoedBnQ=; b=n9cRBA6AcyjbMjKU1QkFj8lZ8u E2CEQ/St7wgl/pkmB56+hDr1MtvR0b+Xu9qbG/85vq0d1Si3HvcaZNQV+DWwig0JD2LTooeSwURBe o2Jl3Yjbcrt9NPa65iN75zjyq; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:54624 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fvOWQ-003ZmR-Lq; Thu, 30 Aug 2018 10:06:10 -0500 From: Tom Tromey To: Simon Marchi Cc: , Keith Seitz Subject: Re: [PATCH] Fix compile-cplus-types.c build errors References: <1535640184-20543-1-git-send-email-simon.marchi@ericsson.com> Date: Thu, 30 Aug 2018 15:06:00 -0000 In-Reply-To: <1535640184-20543-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Thu, 30 Aug 2018 10:43:04 -0400") Message-ID: <87sh2v3ndq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00829.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Fix the third one by comparing to 0 instead. I think the current Simon> comparison simply uses the wrong enum type. Comparing to 0 seems like Simon> the right thing to do, because we want to check whether any flags are Simon> specified. I think this is fine, but at the same time, it seems reasonable to me to want to compare an enum flags object against an enumerator from the underlying type. So maybe enum_flags should have operator== and operator!=. What do you think of this? I am trying to think of a counter-example where this would cause problems. Simon> * compile/compile-cplus-types.c Simon> (compile_cplus_instance::enter_scope): Take the address of scope Simon> object. Simon> (compile_cplus_instance::leave_scope): Likewise. Simon> (compile_cplus_instance::convert_qualified_base): Compare quals Simon> to 0. Looks good. Tom