From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Eliminate target_have_continuable_watchpoint
Date: Fri, 31 Aug 2018 15:43:00 -0000 [thread overview]
Message-ID: <87sh2uzgme.fsf@tromey.com> (raw)
In-Reply-To: <d6effa71-6c09-560f-632f-55bca9488576@redhat.com> (Pedro Alves's message of "Fri, 31 Aug 2018 16:40:27 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>> I think the comment just before this function should also be removed.
Pedro> I thought it was still useful as is. It's describing x86 watchpoints
Pedro> generically enough before a set of functions implementing watchpoints
Pedro> support that I thought that it's still positioned in a good place as
Pedro> is. WDYT?
I looked at that but I didn't understand how the comment related to the
nearby code; like I didn't see anything else in that file about the
status register. However I think it's a minor point and if it makes
sense to you it is fine.
Tom
next prev parent reply other threads:[~2018-08-31 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 15:12 [PATCH 0/2] continuable/steppable/non-steppable watchpoints Pedro Alves
2018-08-31 15:12 ` [PATCH 1/2] Eliminate target_have_continuable_watchpoint Pedro Alves
2018-08-31 15:33 ` Tom Tromey
2018-08-31 15:40 ` Pedro Alves
2018-08-31 15:43 ` Tom Tromey [this message]
2018-08-31 17:52 ` Pedro Alves
2018-08-31 15:12 ` [PATCH 2/2] Add comment describing continuable/steppable/non-steppable watchpoints Pedro Alves
2018-08-31 15:41 ` Tom Tromey
2018-08-31 17:56 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh2uzgme.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox