From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31307 invoked by alias); 4 Oct 2018 12:43:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31291 invoked by uid 89); 4 Oct 2018 12:43:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1011 X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Oct 2018 12:43:15 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 4FA346927 for ; Thu, 4 Oct 2018 07:43:13 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 82xygc63LRPoj82y9gvJKL; Thu, 04 Oct 2018 07:43:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DKsHeHm8gR1Tvrm26r+Sj7WtmSxefvEII3lJJPY8OtQ=; b=YVeA715PEJYxgABC2Ip1nPX6Ud nLQgz4JhYHA0h5gR8J01iXCeaNCUiB9tpkAnHSzD+goNA5aafZ9mZ+aDlqtvCZLqwdIGjM5yTRyQi 8PiLjkpzZH9ENwqtE384MA/uu; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:50280 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g82xx-003eYu-Vy; Thu, 04 Oct 2018 07:42:54 -0500 From: Tom Tromey To: Simon Marchi Cc: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/8] Simple -Wshadow=local fixes References: <20180923040814.27941-1-tom@tromey.com> <20180923040814.27941-2-tom@tromey.com> <3ce6c920-3474-d5a3-db27-4fffc1d2d5b3@ericsson.com> <1bd3f5fc355ca6ef125b1e51a4371861@polymtl.ca> Date: Thu, 04 Oct 2018 12:43:00 -0000 In-Reply-To: <1bd3f5fc355ca6ef125b1e51a4371861@polymtl.ca> (Simon Marchi's message of "Thu, 04 Oct 2018 08:22:05 -0400") Message-ID: <87sh1lj31u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2018-10/txt/msg00105.txt.bz2 >>>>> "Simon" =3D=3D Simon Marchi writes: >> CXX mdebugread.o >> /home/emaisin/src/binutils-gdb/gdb/mdebugread.c: In function =E2=80=98vo= id >> parse_partial_symbols(minimal_symbol_reader&, objfile*)=E2=80=99: >> /home/emaisin/src/binutils-gdb/gdb/mdebugread.c:3573:42: warning: >> =E2=80=98name=E2=80=99 may be used uninitialized in this function >> [-Wmaybe-uninitialized] >> add_psymbol_to_list (name, strlen (name), 1, >> ^ >>=20 >> Simon Simon> I don't get the warning with a recent-ish gcc build from source: Simon> gcc (GCC) 9.0.0 20180906 (experimental) Simon> so it might very well be a false positive. That function is so big I Simon> can't really tell... No, it's really a bug in my patch. I'm not sure if it was always a bug or if it was introduced by some rebase, but given the rate of change of mdebugread I would guess the former. I have a fix, but now I plan to go re-read the patches again to try to make sure I didn't introduce any more bugs. Tom