From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112114 invoked by alias); 30 Oct 2018 03:49:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112051 invoked by uid 89); 30 Oct 2018 03:49:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,TRACKER_ID autolearn=no version=3.3.2 spammy=237A, 7628, 0287, 31F4 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Oct 2018 03:49:09 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 29D2537E74; Tue, 30 Oct 2018 03:49:08 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id F060C17188; Tue, 30 Oct 2018 03:49:07 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: GDB Patches , Pedro Alves Subject: Re: [PATCH] Remove relational operators from common/offset-type.h References: <20181025211008.12164-1-sergiodj@redhat.com> <20181029211401.21602-1-sergiodj@redhat.com> <692dbc7e4c7e6f1f6ceccf9fb5711880@polymtl.ca> Date: Tue, 30 Oct 2018 03:49:00 -0000 In-Reply-To: <692dbc7e4c7e6f1f6ceccf9fb5711880@polymtl.ca> (Simon Marchi's message of "Mon, 29 Oct 2018 23:17:37 -0400") Message-ID: <87sh0oaybw.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00706.txt.bz2 On Monday, October 29 2018, Simon Marchi wrote: > On 2018-10-29 17:14, Sergio Durigan Junior wrote: >> This patch is a follow-up of: >> >> https://sourceware.org/ml/gdb-patches/2018-10/msg00601.html >> >> It removes the declaration of the relational operators for >> common/offset-type.h. As it turns out, these overloads are not being >> used when a new offset type is declared, because, according to Pedro >> Alves: >> >> I think the functions aren't called because they are templates, and >> thus the built-in (non-template) versions take precedence. If you >> make them non-templates, then they should be called. But, the >> built-ins are fine, so yeah, we can just remove the custom >> definitions. >> >> The patch also adjusts the comments on the code. >> >> No regressions introduced. >> >> gdb/ChangeLog: >> 2018-10-29 Sergio Durigan Junior >> >> * common/offset-type.h (DEFINE_OFFSET_REL_OP): Delete. >> Adjust comments. > > Thanks, LGTM. Thanks, pushed. fd332753fa7050bb9d7c89147e32d285099fe402 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/