Re: [PATCH v2] Implement timestamp'ed output on "make check"

Sergio Durigan Junior
2018-11-25T23:23:31Z

On Sunday, November 25 2018, Simon Marchi wrote:

> On 2018-11-25 11:24, Sergio Durigan Junior wrote:
>>> As for the coding style, according to the wiki [1], we should
>>> follow PEP8 (which
>>> I think makes sense). Can you change your script to folow that?
>>> "autopep8 -i print-ts.py" should do it.
>>
>> Hm, the command doesn't output anything to me, and $? = 0. Is there
>> anything in particular that you noticed?
>
> The command modifies the file in-place, so you should have unstaged
> changes after running it. In particular, it should remove spaces
> before parentheses.

Ah, OK. I'm not used to tools that don't ask me whether I'd like to
modify a file. And FWIW, I don't really like this part of PEP8 which
states that there should be no spaces before parentheses.

Anyway, I've pushed the commit now:

f63c03b470036353c8c6c657e15f5ebd62ab67dd

Thanks again for the review.

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible