Re: [PATCH] Implement timestamp'ed output on "make check"

Sergio Durigan Junior
2018-12-08T23:16:46Z

On Saturday, December 08 2018, Pedro Alves wrote:

> On 12/07/2018 10:09 PM, Sergio Durigan Junior wrote:
>> On Friday, December 07 2018, Pedro Alves wrote:
>>
>>> On 12/06/2018 07:52 PM, Sergio Durigan Junior wrote:
>>>> The results can be found at <https://gdb-build.sergiodj.net/results/>,
>>>> but you're, you just have access to the consolidated gdb.log, not the
>>>> different logs under output/.
>>>
>>> Given the above, then I have to ask: what's the advantage of the
>>> new timestamped output mode? Why not just extract the info out
>>> of the gdb.log file? It's less code to maintain, and you don't
>>> have to remember to run the testsuite in a special mode, nor
>>> record stdout of the test run.
>>
>> When I was writing the timestamp script, I didn't think about extracting
>> the info from gdb.log. So there's that. I agree that it's easier to
>> have the consolidated info at the end, and I can propose a patch for
>> that based on your shell script,
>
> I think you're missing that we don't even need my previous script. As Pedro said:
>
> "Still, the merged gdb.log file seems to already have the completion
> ^^^^^^
> times, e.g.:
>
> testcase [...]gdb.trace/unavailable.exp completed in 28 seconds"
>
>
> So all we need is something like this:
>
> $ grep "completed in " testsuite/gdb.log | awk '{print $5 " seconds for " $2}' | sort -n | tail -n 10
> 20 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/fork-running-state.exp
> 23 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/gnu-ifunc.exp
> 28 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/attach-pie-misread.exp
> 28 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/foll-vfork.exp
> 29 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/attach.exp
> 31 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/checkpoint.exp
> 32 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/checkpoint-ns.exp
> 37 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/dprintf-detach.exp
> 49 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/gdb-sigterm.exp
> 78 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/break-interp.exp

Ah, sorry, indeed I was missing this point. Well, in any case, we need
some kind of script, right? I think it'd be a good idea to generate
this report at the end of the test run, and put it into a file under the
testsuite dir, WDYT?

Thanks,

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible