From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99646 invoked by alias); 17 Feb 2019 23:31:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98904 invoked by uid 89); 17 Feb 2019 23:31:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Feb 2019 23:31:02 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 7C06540140B2A for ; Sun, 17 Feb 2019 17:28:00 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vVqqg6PLEYTGMvVqqgP8AZ; Sun, 17 Feb 2019 17:28:00 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ALQDdeu2RhIhNhDDja12+Zq1lfVGaqeTqve4P/mC+AU=; b=ZVpxIgP5XBIMl2h5y79yV7ejoY W1sguHaXN7qJyTBGLZsr5gQZFoJJXPA2gGtrzy5vVmPHtmY5Km4XvfHR7QOfNlcdq2ef21tgWxNK4 LDeN8HPHn/vm0PVQFZLNBmmaR; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:37092 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gvVqq-000mwu-8E; Sun, 17 Feb 2019 17:28:00 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix leaks of 'per program space' and 'per inferior' ada task data. References: <20190217195037.25482-1-philippe.waroquiers@skynet.be> Date: Sun, 17 Feb 2019 23:31:00 -0000 In-Reply-To: <20190217195037.25482-1-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sun, 17 Feb 2019 20:50:37 +0100") Message-ID: <87sgwmknb4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00275.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> + if (data != NULL) Philippe> + XDELETE (data); gdb normally uses "xfree" and not XDELETE. Also the NULL check isn't needed. Philippe> + if (data != NULL) Philippe> + delete data; You don't need the NULL check here either. This is ok with these changes. Thank you for the patch. Tom