From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, Jim Wilson <jimw@sifive.com>,
John Baldwin <jhb@freebsd.org>,
Palmer Dabbelt <palmer@sifive.com>, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH 1/2] gdb: Fix alignment computation for structs with only static fields
Date: Sun, 07 Apr 2019 22:36:00 -0000 [thread overview]
Message-ID: <87sgute93k.fsf@tromey.com> (raw)
In-Reply-To: <fc5e30e2581ca0ae46f1b51ad01e9fb2c5ae6cae.1554672870.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Sun, 7 Apr 2019 22:37:54 +0100")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> gdb/ChangeLog:
Andrew> * gdbtypes.c (type_align): A struct with no non-static fields also
Andrew> has alignment of 1.
Andrew> gdb/testsuite/ChangeLog:
Andrew> * gdb.base/align.exp: Extend test to cover structures containing
Andrew> only static fields.
Thanks for doing this.
It looks good to me.
Tom
next prev parent reply other threads:[~2019-04-07 22:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-07 21:38 [PATCH 0/2] More type_align fixes Andrew Burgess
2019-04-07 21:38 ` [PATCH 1/2] gdb: Fix alignment computation for structs with only static fields Andrew Burgess
2019-04-07 22:36 ` Tom Tromey [this message]
2019-04-07 21:38 ` [PATCH 2/2] gdb/riscv: Remove riscv_type_alignment function Andrew Burgess
2019-04-11 22:42 ` [PATCH 0/2] More type_align fixes Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgute93k.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@freebsd.org \
--cc=jimw@sifive.com \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox