From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105355 invoked by alias); 16 Apr 2019 19:43:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105347 invoked by uid 89); 16 Apr 2019 19:43:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Apr 2019 19:43:27 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 09FC716539B for ; Tue, 16 Apr 2019 14:43:26 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id GTzJh6Sw890onGTzKhHcEr; Tue, 16 Apr 2019 14:43:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cLrjlbnYBnFNEQCacNt+akkruFQ0RKo8kEMI2lr9pRI=; b=At/hthXUT7VV8Q/Telm7x6zaN9 jP6YUCrJaWFw+RG7E00hvR68Sj9+oC6oW5Tf7m6aHo82h3M5BjWWAf9falQLdLUWMS/2t3UEEJiQk LAbsIwQcea/G9HT1LNCa7ucls; Received: from 75-166-39-124.hlrn.qwest.net ([75.166.39.124]:45770 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hGTzJ-004F8d-PW; Tue, 16 Apr 2019 14:43:25 -0500 From: Tom Tromey To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH 3/4] gdbserver: Ensure all debug output uses debug functions References: <20190416101729.16176-1-alan.hayward@arm.com> <20190416101729.16176-4-alan.hayward@arm.com> Date: Tue, 16 Apr 2019 19:43:00 -0000 In-Reply-To: <20190416101729.16176-4-alan.hayward@arm.com> (Alan Hayward's message of "Tue, 16 Apr 2019 10:17:42 +0000") Message-ID: <87sguhsplu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00277.txt.bz2 >>>>> "Alan" == Alan Hayward writes: Alan> All debug output needs to go via debug functions to ensure it writes to the Alan> correct output stream. Alan> gdb/ChangeLog: Alan> 2019-04-16 Alan Hayward Alan> * nat/linux-waitpid.c (linux_debug): Call debug_vprintf. Alan> gdb/gdbserver/ChangeLog: Alan> 2019-04-16 Alan Hayward Alan> * ax.c (ax_vdebug): Call debug_printf. Alan> * debug.c (debug_write): New function. Alan> * debug.h (debug_write): New declaration. Alan> * linux-low.c (sigchld_handler): Call debug_write. Thanks, this is ok. Tom