From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2] two ptype/o changes
Date: Wed, 08 May 2019 16:14:00 -0000 [thread overview]
Message-ID: <87sgtoly8b.fsf@tromey.com> (raw)
In-Reply-To: <20190429183105.15973-1-tromey@adacore.com> (Tom Tromey's message of "Mon, 29 Apr 2019 12:31:03 -0600")
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
Tom> This series changes ptype/o in a couple of ways.
Tom> Last week I spent quite some time puzzling over the meaning of the
Tom> 'offset' for a bitfield in ptype/o output. After talking with Sergio
Tom> on irc, I ended up concluding that gdb should instead print the bit
Tom> offset, not the number of bits remaining in the field's allocation.
Tom> That is patch #2. Then, I noticed that the tests did not fail,
Tom> despite the output changing. It turns out the tests weren't working
Tom> correctly, so I wrote patch #1.
Tom> Tested on x86-64 Fedora 29. Let me know what you think.
Tom> Patch #2 includes a doc change.
I'm checking this in now.
Tom
prev parent reply other threads:[~2019-05-08 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 18:31 Tom Tromey
2019-04-29 18:31 ` [PATCH 2/2] Change ptype/o to print bit offset Tom Tromey
2019-04-29 18:52 ` Eli Zaretskii
2019-04-29 18:57 ` Tom Tromey
2019-04-29 20:10 ` John Baldwin
2019-05-08 16:14 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgtoly8b.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox