From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20528 invoked by alias); 5 Dec 2019 14:40:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20520 invoked by uid 89); 5 Dec 2019 14:40:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Dec 2019 14:40:39 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 515FDE7543 for ; Thu, 5 Dec 2019 08:40:38 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id csJ3if94CqNtvcsJ3iPAQe; Thu, 05 Dec 2019 08:40:38 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=O4oYZhwCOqF3uAUvfBJawDYAH6KYpXaDtlZ4D1PsF9A=; b=JMIA0ocj/SsOFSg6IplGDqzDs1 6iNw2TkPuRGhJmHfz6xZ4RP4tu+xIIws4/1o3eQKyKLJb7e0FUQWJCpP/uZYDsnA8IpVueH0SA1F5 KgZJpXhLnG31pthXh1fQLJzuw; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:59030 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1icsJ3-003B7O-DG; Thu, 05 Dec 2019 07:40:37 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove gdbarch parameter of lookup_typename References: <20191205050916.230459-1-simon.marchi@polymtl.ca> Date: Thu, 05 Dec 2019 14:40:00 -0000 In-Reply-To: <20191205050916.230459-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Thu, 5 Dec 2019 00:09:16 -0500") Message-ID: <87sgly96or.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00177.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I noticed that the gdbarch parameter of lookup_typename was unused, so I Simon> removed it (as well as from lookup_signed_typename and Simon> lookup_unsigned_typename) and updated all callers. This looks fine to me. Thanks for doing this. I do wonder a bit why the parameter was there in the first place. Maybe this code used to look at the per-arch types? Tom