From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.200.11]) by sourceware.org (Postfix) with ESMTPS id 2C2CE386101E for ; Thu, 3 Sep 2020 14:17:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2C2CE386101E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway36.websitewelcome.com (Postfix) with ESMTP id CE68A401F958A for ; Thu, 3 Sep 2020 08:42:37 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Dq36ksOBCn9FWDq36kNrDd; Thu, 03 Sep 2020 09:17:12 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UcZFaJtoKT3sVuAO+k1O99hV5rVcWARbSpR0dyiAuHw=; b=XhVDXA1oWyc1Yeol+j80sl0qeN J63xp6WdIWbZL7AIeDLWig+8HnjIQatpjy8Fb4J+3hYV3nxf0YViqlL5Q2X6/F9J7drNVavQVvTF4 UyiS5hI1Nbil4GLmuxtHa93vW; Received: from 97-118-98-94.hlrn.qwest.net ([97.118.98.94]:56078 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kDq35-003OIE-RX; Thu, 03 Sep 2020 08:17:11 -0600 From: Tom Tromey To: Kamil Rytarowski Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 01/10] Add handle_eintr to wrap EINTR handling in syscalls References: <20200902175926.13182-1-n54@gmx.com> <20200902175926.13182-2-n54@gmx.com> X-Attribution: Tom Date: Thu, 03 Sep 2020 08:17:11 -0600 In-Reply-To: <20200902175926.13182-2-n54@gmx.com> (Kamil Rytarowski's message of "Wed, 2 Sep 2020 19:59:17 +0200") Message-ID: <87sgbzq714.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.98.94 X-Source-L: No X-Exim-ID: 1kDq35-003OIE-RX X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-98-94.hlrn.qwest.net (murgatroyd) [97.118.98.94]:56078 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Sep 2020 14:17:21 -0000 >>>>> "Kamil" == Kamil Rytarowski writes: Kamil> +2020-03-17 Kamil Rytarowski Kamil> + Kamil> + * eintr.h: Add handle_eintr. Kamil> +template Kamil> +inline decltype (auto) handle_eintr (const Fun &F, const Args &... A) I like this, but from what I read it seems that "decltype(auto)" is C++14 -- but gdb is still C++11. Kamil> +{ Kamil> + decltype (F (A...)) ret; Kamil> + do Kamil> + { Kamil> + errno = 0; Kamil> + ret = F (A...); Kamil> + } Kamil> + while (ret == -1 && errno == EINTR); Also this seems to assume that "ret" is comparable to an int anyway. So maybe just assuming int everywhere would be ok. Tom