Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Disable bracketed paste mode in GDB tests
Date: Fri, 22 Jan 2021 08:18:05 -0700	[thread overview]
Message-ID: <87sg6tov9u.fsf@tromey.com> (raw)
In-Reply-To: <87y2gl98lf.fsf@tromey.com> (Tom Tromey's message of "Thu, 21 Jan 2021 16:24:44 -0700")

Tom> Hmm.  I do see this with the system gdb:
Tom>     readline: /tmp/INP: line 1: foo: unknown variable name

I see it now with my built gdb as well.
I don't know why I did not see it before :(

Tom> Also I am not sure about the $if solution, given that readline 8.1 has a
Tom> bug here.  We can fix that in-tree, but that fix won't work for a system
Tom> readline build.  Ugh.

Using the $if-less patch will cause a warning, but apparently this does
not negatively affect the tests.

On the other hand, the patch using $if will cause many failures if gdb
is linked against a version of Readline 8.1 with the $if bug.

So, I think the best approach is to use the variant without the $if.

Tom

  reply	other threads:[~2021-01-22 15:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 19:20 Tom Tromey
2021-01-18 19:26 ` Andreas Schwab
2021-01-18 19:35   ` Tom Tromey
2021-01-18 19:52     ` Tom Tromey
2021-01-18 20:01     ` Andreas Schwab
2021-01-21 23:24       ` Tom Tromey
2021-01-22 15:18         ` Tom Tromey [this message]
2021-01-23 15:43 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg6tov9u.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox