From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cCPyAYaTIWCxSAAAWB0awg (envelope-from ) for ; Mon, 08 Feb 2021 14:39:50 -0500 Received: by simark.ca (Postfix, from userid 112) id 060CD1EF4F; Mon, 8 Feb 2021 14:39:50 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 305541E4A3 for ; Mon, 8 Feb 2021 14:39:49 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BAD2A38708A4; Mon, 8 Feb 2021 19:39:48 +0000 (GMT) Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.144.96]) by sourceware.org (Postfix) with ESMTPS id CBFA838708A4 for ; Mon, 8 Feb 2021 19:39:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CBFA838708A4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 6A3223574ED for ; Mon, 8 Feb 2021 13:39:46 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9CNul30K6uDoA9CNul2wai; Mon, 08 Feb 2021 13:39:46 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Cfauk1/Qu4qP2MjPIFlhEbGYM/4s1yr2w3BEQm6GDG4=; b=rY9jlEcCsmvr9Y4MQZoR92Nr9v zRb+CG9W9j15tDscKMQiobjc5fWwaWwZ5VzhSDWodKLUrxxyUxI2PpCkOqD0i1smi4G0xXkDdrrGC Rs6hnVnivStjWlSnPZMYzdi3x; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:37030 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l9CNt-001QTp-T5; Mon, 08 Feb 2021 12:39:45 -0700 From: Tom Tromey To: Mike Frysinger via Binutils Subject: Re: [PATCH] config/debuginfod: do not include pkg.m4 directly References: <20210207003141.14617-1-vapier@gentoo.org> X-Attribution: Tom Date: Mon, 08 Feb 2021 12:39:45 -0700 In-Reply-To: <20210207003141.14617-1-vapier@gentoo.org> (Mike Frysinger via Binutils's message of "Sat, 6 Feb 2021 19:31:41 -0500") Message-ID: <87sg66fiwu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l9CNt-001QTp-T5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:37030 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Mike" == Mike Frysinger via Binutils writes: Mike> Any code using AC_DEBUGINFOD from this dir is using -I../config when Mike> running aclocal, so an explicit include on pkg.m4 is unnecessary: Mike> aclocal will find the pkg.m4 in this dir just as easily. This is Mike> seen in the only two dirs that use AC_DEBUGINFOD (binutils & gdb) Mike> as their aclocal.m4 already has m4_include on config m4 files. Mike> The include as written only works if aclocal is run on a dir that is Mike> config/ Mike> * debuginfod.m4: Delete m4_include(../config/pkg.m4). Mike> binutils/ Mike> * aclocal.m4: Regenerate. Mike> gdb/ Mike> * aclocal.m4: Regenerate. This is fine by me, but please wait a little while in case someone on the binutils list has a differing opinion. thanks, Tom