From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id x/tlHBW7NmCrIAAAWB0awg (envelope-from ) for ; Wed, 24 Feb 2021 15:46:13 -0500 Received: by simark.ca (Postfix, from userid 112) id 654D31EF78; Wed, 24 Feb 2021 15:46:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 096C81E789 for ; Wed, 24 Feb 2021 15:46:13 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C44F3953CF3; Wed, 24 Feb 2021 20:46:12 +0000 (GMT) Received: from gateway21.websitewelcome.com (unknown [192.185.45.2]) by sourceware.org (Postfix) with ESMTPS id 5F775385481F for ; Wed, 24 Feb 2021 20:46:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5F775385481F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway21.websitewelcome.com (Postfix) with ESMTP id F13DD400DF908 for ; Wed, 24 Feb 2021 14:46:09 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id F12vlkAjeoE4DF12vldzaW; Wed, 24 Feb 2021 14:46:09 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0Dyr15AlYJLZixJq/tT5YdVBtxq9dNyOXj1/STQwtA0=; b=UYAakbXnJzLwfRqFdI/329pc0f RD3mxXzkLl+hR9Tn7/AnEjTh6Z8+mv6ALHRLTdKp1/s0QeVSS1FczkWDWLUcDF6IHY1xI3gPcsBAA oqimEZNC6TbXv0AEUmz0smFHv; Received: from 97-122-70-152.hlrn.qwest.net ([97.122.70.152]:43360 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lF12v-004G1Z-Dr; Wed, 24 Feb 2021 13:46:09 -0700 From: Tom Tromey To: Tom de Vries Subject: Re: [RFC][gdb/symtab] Add DW_IDX_GNU_main_subprogram References: <20210129154749.GA15479@delia> <87k0rm5ygc.fsf@tromey.com> <063bff26-f377-6e50-b1ce-d9e74b2d37cf@suse.de> X-Attribution: Tom Date: Wed, 24 Feb 2021 13:46:08 -0700 In-Reply-To: <063bff26-f377-6e50-b1ce-d9e74b2d37cf@suse.de> (Tom de Vries's message of "Mon, 8 Feb 2021 12:46:56 +0100") Message-ID: <87sg5lyz1r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.70.152 X-Source-L: No X-Exim-ID: 1lF12v-004G1Z-Dr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-70-152.hlrn.qwest.net (murgatroyd) [97.122.70.152]:43360 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> I tried fixing this by adding a GNU extension DW_IDX_GNU_main_subprogram Tom> to .debug_names. Nice idea. Tom> Fix this by adding a GNU extension DW_IDX_GNU_main_subprogram to the name Tom> index attributes, encoded using a number in the DW_IDX_lo_user-DW_IDX_hi_user Tom> range. It seems unfortunate to have to read most of the index entries in order to find this at startup. How much slowdown does it cause? Tom> + /* Set main name and language. */ Tom> + for (int i = 0; i < per_bfd->debug_names_table->name_count; ++i) Tom> + { Tom> + const auto &map = *per_bfd->debug_names_table; It seems like this could be hoisted out of the loop and then also used in the loop header. Tom