[PATCH 02/16] gdb: add some const in gdb/reggroups.c

Andrew Burgess via Gdb-patches
2022-03-31T21:05:52Z

This commit makes the 'struct reggroup *' argument const for the
following functions:

reggroup_next
reggroup_prev
reggroup_name
reggroup_type

There are other places that could benefit from const in the
reggroup.{c,h} files, but these will be changing in further commits.

There should be no user visible changes after this commit.
---
gdb/reggroups.c | 8 ++++----
gdb/reggroups.h | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/gdb/reggroups.c b/gdb/reggroups.c
index b6afa2f895c..169285b7475 100644
--- a/gdb/reggroups.c
+++ b/gdb/reggroups.c
@@ -63,13 +63,13 @@ reggroup_gdbarch_new (struct gdbarch *gdbarch, const char *name,
/* Register group attributes. */

const char *
-reggroup_name (struct reggroup *group)
+reggroup_name (const struct reggroup *group)
{
return group->name;
}

enum reggroup_type
-reggroup_type (struct reggroup *group)
+reggroup_type (const struct reggroup *group)
{
return group->type;
}
@@ -130,7 +130,7 @@ static struct reggroups default_groups = { NULL, &default_groups.first };
/* A register group iterator. */

struct reggroup *
-reggroup_next (struct gdbarch *gdbarch, struct reggroup *last)
+reggroup_next (struct gdbarch *gdbarch, const struct reggroup *last)
{
struct reggroups *groups;
struct reggroup_el *el;
@@ -161,7 +161,7 @@ reggroup_next (struct gdbarch *gdbarch, struct reggroup *last)
/* See reggroups.h. */

struct reggroup *
-reggroup_prev (struct gdbarch *gdbarch, struct reggroup *curr)
+reggroup_prev (struct gdbarch *gdbarch, const struct reggroup *curr)
{
struct reggroups *groups;
struct reggroup_el *el;
diff --git a/gdb/reggroups.h b/gdb/reggroups.h
index f2e60c4f1da..ef99483f39f 100644
--- a/gdb/reggroups.h
+++ b/gdb/reggroups.h
@@ -50,17 +50,17 @@ extern struct reggroup *reggroup_gdbarch_new (struct gdbarch *gdbarch,
extern void reggroup_add (struct gdbarch *gdbarch, struct reggroup *group);

/* Register group attributes. */
-extern const char *reggroup_name (struct reggroup *reggroup);
-extern enum reggroup_type reggroup_type (struct reggroup *reggroup);
+extern const char *reggroup_name (const struct reggroup *reggroup);
+extern enum reggroup_type reggroup_type (const struct reggroup *reggroup);

/* Iterators for the architecture's register groups. Pass in NULL, returns
the first (for next), or last (for prev) group. Pass in a group,
returns the next or previous group, or NULL when either the end or the
beginning of the group list is reached. */
extern struct reggroup *reggroup_next (struct gdbarch *gdbarch,
- struct reggroup *last);
+ const struct reggroup *last);
extern struct reggroup *reggroup_prev (struct gdbarch *gdbarch,
- struct reggroup *curr);
+ const struct reggroup *curr);
/* Find a reggroup by name. */
extern reggroup *reggroup_find (struct gdbarch *gdbarch, const char *name);

--
2.25.4