Re: [PATCH 2/2] gdb: Improve the resuming of the stepped thread

[Thiago Jung Bauermann via Gdb-patches <gdb-patches@sourceware.org>]

Hello Eduard,

Eduard Sargsyan via Gdb-patches <gdb-patches@sourceware.org> writes:

> From: Aleksandar Paunovic <aleksandar.paunovic@intel.com>
>
> Stepped thread should not be resumed (again) if the next stopping point
> (next stopping PC) cannot be determined.  Do not resume the stepped thread
> in this case.  Resuming would lead to an inconsistent state where the
> stepped thread would be running forever and GDB would never get to
> breakpoints of the other threads.  */
>
> gdb/ChangeLog:
> 2021-04-30  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
>
>         * infrun.c (keep_going_stepped_thread): Do not resume an
> 	already executing thread.
>
> gdb/testsuite/ChangeLog:
> 2021-04-30  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
>
> 	* gdb.base/breakpoint-running-inferior.exp: Add a start_step
> 	function check.
>
> Signed-off-by: Aleksandar Paunovic <aleksandar.paunovic@intel.com>
> ---
>  gdb/infrun.c                                      | 15 ++++++++++++++-
>  .../gdb.base/breakpoint-running-inferior.exp      |  5 +++++
>  2 files changed, 19 insertions(+), 1 deletion(-)

When Andrew Burgess reviewed this patch, Aleksandar said¹:

> Actually now when I tested this further I saw that this check (the whole patch) is
> unnecessary because GDB recovers successfully.
> Originally the regcache_read_pc function call (10 lines below my change) was throwing "PC
> register is not available" but it seems in the meantime this is fixed.
> I will put only first patch for review.

Has anything changed since then?

-- 
Thiago

¹ https://inbox.sourceware.org/gdb-patches/DM6PR11MB25889C3D6F45819B7D86EAE2F0319@DM6PR11MB2588.namprd11.prod.outlook.com/