From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YMIWJ4pM/GWUYxAAWB0awg (envelope-from ) for ; Thu, 21 Mar 2024 11:04:42 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=RF07/qXH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 87D9A1E0C0; Thu, 21 Mar 2024 11:04:42 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4DF061E030 for ; Thu, 21 Mar 2024 11:04:40 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E4EAD385841F for ; Thu, 21 Mar 2024 15:04:39 +0000 (GMT) Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 1185B3858D28 for ; Thu, 21 Mar 2024 15:04:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1185B3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1185B3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711033462; cv=none; b=haXt47JvfqimdcuICgv7F5ktEJkuOEw89uyl0PJwgQKD7fR+ZfoE2R/wt34Fgrzdm/QpKfK5TaUeWOmjp/f+B8Jaisb9H9Hf20z2n43WbA9a6Bp+XPmW/D+Zn+CEybVSihbjCe36W9gxdL+2lqlS8FXAZCT4TZt8UstQfGmzuh8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711033462; c=relaxed/simple; bh=Epeg5NhFrxVX5dIAddvNWOeeAY0aERmkMdi3ovC32CA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=pRVmDnudG/8ewsdlfaPvTOgx2p3/72gk/ttGSsYANmP92uFt3I1MWv7Pcy1D6B7M5iqPb+XN5SDtv1r+CK/JOC64Cq+hlS2ye8bBlpVazn6G1QN9WPOBI4VxuoNsIO1nJy9q6anb/ZVvLPaQEINBAC0l+JYG+Kwz1sJCFOyc3J8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6002a.ext.cloudfilter.net ([10.0.30.222]) by cmsmtp with ESMTPS id mz9wrrWGNPM1hnJxjruRYo; Thu, 21 Mar 2024 15:04:11 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id nJxirZ1g4iKqRnJxirrUY9; Thu, 21 Mar 2024 15:04:10 +0000 X-Authority-Analysis: v=2.4 cv=I9quR8gg c=1 sm=1 tr=0 ts=65fc4c6a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=pGLkceISAAAA:8 a=qUXFsv20AAAA:8 a=mlwOfrHi74WtQ6FakZoA:9 a=OfbOyEJMMrEA:10 a=9MODbo6-FXLeArg8YEg9:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NkIqheQ8i+f+ALs7800UDKHE3b5vLG1MdM3tKdkTrUs=; b=RF07/qXHiW4qIZEV7jDdSsPaRM Y0dzIqsuz7qrt89klHRk+4ZNzviDtQk/M0yN8sMSrgtF3JqO2jbmPlc/Wq7gjoOP1VVui7sIDTw3V yexct4ibUgzlYoBn5sxbIlxNe; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:32924 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rnJxh-003Hph-38; Thu, 21 Mar 2024 09:04:10 -0600 From: Tom Tromey To: Orgad Shaneh Cc: gdb-patches@sourceware.org, Jon Turney Subject: Re: [PATCH] Better handling for realpath() failures in windows_make_so() on Cygwin References: <20240321065417.1125-1-orgad.shaneh@audiocodes.com> <20240321072349.1160-1-orgads@gmail.com> X-Attribution: Tom Date: Thu, 21 Mar 2024 09:04:09 -0600 In-Reply-To: <20240321072349.1160-1-orgads@gmail.com> (Orgad Shaneh's message of "Thu, 21 Mar 2024 09:22:53 +0200") Message-ID: <87sf0jeidy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rnJxh-003Hph-38 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:32924 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCFXaR+iA2W5vH1Ehj26D9gIkVLMjhjzxuG9NuqRn8jn7EIcSITqHYspvaXTmEi2QCTPyfUOiwG3B2kVhoOlTYuENc2tsi1itRomPW56Aqyo1hm3K/lD AbdF39xh/OAsQlRJVjgapCIkQEy6c02gyfQsi6mC5JBbRUdhJQqlZNj7pO3JarGRYCyxDNI0w+7EyQ7qHhMglniYifcIqXkeN+0= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Orgad" == Orgad Shaneh writes: Orgad> From: Jon Turney Orgad> Fix a memory leak which would occur in the case when the result of realpath() is Orgad> greater than or equal to SO_NAME_MAX_PATH_SIZE. Thanks for the patch. Orgad> + if (rname) Orgad> + free (rname); No need to check for NULL when calling free -- and gdb uses 'xfree' anyway. However, it would be better to change this code to use gdb_realpath, which returns a unique pointer. Then the memory leak will be impossible. Could you try that instead? thanks, Tom