From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id usOxAwGL8WbypTQAWB0awg (envelope-from ) for ; Mon, 23 Sep 2024 11:36:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QKRi9qe7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E8EC91E353; Mon, 23 Sep 2024 11:36:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4004E1E05C for ; Mon, 23 Sep 2024 11:36:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 905AC385842C for ; Mon, 23 Sep 2024 15:36:31 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id F110F3858D26 for ; Mon, 23 Sep 2024 15:36:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F110F3858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F110F3858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727105771; cv=none; b=KkpZ6nQh4X7PashxC+YpsajLIx+0+vGZYsH0pukhThoWWILXJVmr+N+xS2xnPVfhvVYsmMMa+08Q2J4De9Wn5uiPNcwr3JvBUrp3QZYZQeNnCbVt5+likYwsBdBHOGIePz3Ao7bNgHC3BNk8/XR7Iluefkla0bLOT0QFX0HspNU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727105771; c=relaxed/simple; bh=lcMHOobj3SUuHJs6lV9kOqlYZOP372jlXk7siFi2KZI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=n4qazQgGZNrOanWoIr2xpf7gzZlaJoJKFE7krqE6B6QA4gIdhBHJxcD7BPaAS69XHq3sX1mNgnrtl9pJ10eB8SuWewI/SlNDAVcS8jShrI+GyBKHHMl8wG1RHqthmzGc+phn2arSVG4Ql2khl+qOLZ8hIbi8rmwgKkbEu0IJvag= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727105769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fcCSQ9VRjsOe9uSjGVa+6axvlRifvDZCS1wTBd8k76U=; b=QKRi9qe7puYJsAo1f21XsAYWo5cZvzj17xi97feIeSAa3qR/lBoY+VqippuRnVk84LxRlm Wl2h7sZR9zQFaWknvO+djGAuI6S1VZd0yMw95tDMnYILFyCu4wBzL9cB2sgkhuFWCABXfq x2MmOPPFUo02/IHNgCYPsQ0pda24ZJA= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-505-ZOebZUTJPTWM2ywd-FcX9w-1; Mon, 23 Sep 2024 11:36:08 -0400 X-MC-Unique: ZOebZUTJPTWM2ywd-FcX9w-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-5c268497042so2753879a12.0 for ; Mon, 23 Sep 2024 08:36:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727105766; x=1727710566; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fcCSQ9VRjsOe9uSjGVa+6axvlRifvDZCS1wTBd8k76U=; b=vIc3YrbkVF6rWoHLdXlGIzsgbyB4jUTpDIFy4LPIFgkbf1wXnmI7YIhGG63xDnoNYO Lo5xaWVwPPfc6xGCoM9XxM+KuUiYoH1Xskq01iePCmqpH8V3eIXI8ZUR4fGoQJT8c5XL LPp6T8QTi7v30yAnUrHVrqwR9eU5sWgiMgCrbtesDU4Pug4hwAxKW1M0KNAD4tNlhBbx pTLpZXusAm9AbK/4Mrh7LKoLJ+N6zlIWCTetGr3HqbeemKxOyIcz1kKNZLI1NtwmYEx1 MMyGftyDTALXIe2Ny8GShYdtx54yaWQPMr9UNpMV4hPnPpHA6wLFId2RTVaLPpZmE7A2 d9rg== X-Gm-Message-State: AOJu0YwlbkftdNtcLUMrhZwwcoYA36nvV5QwRyXJVH5xfgytVivkfrX9 oYAMQA0yuxKbXlGeHYuSxOvbibw++UeUT84Sg7T6oQ/qHExR3af0gO4DK+lYyGGwIkkMwHDkngT mXJev8HlsV40IWnRNMclavVneFGd3IZ+KkEjUgDaEgQqWKYViGtgewsVJSWtJTChmMJudhcEpJj hwHnU2A1l/kcX3Ur3HGXbu/Lb6+IKTZX9aMkG8UwxWkao= X-Received: by 2002:a05:6402:5483:b0:5be:eb19:ee56 with SMTP id 4fb4d7f45d1cf-5c464dea205mr10023099a12.24.1727105766543; Mon, 23 Sep 2024 08:36:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFdqvW6D8uke9cGXjoiABL7QIaMAblFtZURU2jgX88qQp3QigQ8BPwS7ZWdIM9pq2m69qYZ0A== X-Received: by 2002:a05:6402:5483:b0:5be:eb19:ee56 with SMTP id 4fb4d7f45d1cf-5c464dea205mr10023079a12.24.1727105766009; Mon, 23 Sep 2024 08:36:06 -0700 (PDT) Received: from localhost (178.126.90.146.dyn.plus.net. [146.90.126.178]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bb89d50sm10555881a12.78.2024.09.23.08.36.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2024 08:36:05 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Subject: Re: [PATCHv13 6/6] gdb: only insert thread-specific breakpoints in the relevant inferior In-Reply-To: References: Date: Mon, 23 Sep 2024 16:36:04 +0100 Message-ID: <87setqz8kb.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I spotted a comment in this commit which I'd not updated correctly as the series developed. I pushed the patch below to fix this. Thanks, Andrew --- commit 43a1fffa62060ce640749dcc9fc17058069ccba6 Author: Andrew Burgess Date: Mon Sep 23 14:30:44 2024 +0100 gdb: update comment in code_breakpoint::re_set_default Spotted a comment in code_breakpoint::re_set_default that was added in commit: commit 6cce025114ccd0f53cc552fde12b6329596c6c65 Date: Fri Mar 3 19:03:15 2023 +0000 gdb: only insert thread-specific breakpoints in the relevant inferior that was incorrect. The comment was not updated to take inferior specific breakpoints into account. This commit just updates the comment, there's no user visible changes after this commit. diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 7fd50ba63fc..d161e24097a 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -13136,9 +13136,10 @@ code_breakpoint::re_set_default (struct program_space *filter_pspace) { std::vector expanded, expanded_end; - /* If this breakpoint is thread-specific then find the program space in - which the specific thread exists. Otherwise, for breakpoints that are - not thread-specific THREAD_PSPACE will be nullptr. */ + /* If this breakpoint is thread- or inferior-specific, then find the + program space in which this breakpoint exists. Otherwise, for + breakpoints that are not thread- or inferior-specific, BP_PSPACE will + be nullptr. */ program_space *bp_pspace = find_program_space_for_breakpoint (this->thread, this->inferior);