From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +0eREtRET2eG0QIAWB0awg (envelope-from ) for ; Tue, 03 Dec 2024 12:50:12 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=K8UfVMvX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3F41F1E0BB; Tue, 3 Dec 2024 12:50:12 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9FEC81E05C for ; Tue, 3 Dec 2024 12:50:11 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4A94D3858C2B for ; Tue, 3 Dec 2024 17:50:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A94D3858C2B Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=K8UfVMvX Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 736853858D33 for ; Tue, 3 Dec 2024 17:49:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 736853858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 736853858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733248171; cv=none; b=lnQFhf6p2/RAMKq7GdHoMub3Zo0U17CA2C9OeaHxcTp8pIotvfmw3eagdxVO5NxTVpGwVLT33cK0Hlmi7s0fBaWqeQVQYgsnbc+1UmoLnzfFJWkRTjWNK1fr2Kg8io/+z2Ync04wvnK0zTiVLzbLsbOMJVOt7cF8FHKk7ki6j4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733248171; c=relaxed/simple; bh=ve4gMeljOZSzdXT9+KnNnFCCF66jr1BTQEemTAKQXlM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hyPm8EkZC9vu9xIaghDY82Fj0kG56a0VB/5j77yXIKjfzDkdQCSSTU5tRBbN5hZZF1CJcvG9o1vy60KJi0kKr5WpKQicsd62EcbW/NbeNM4aNFX9UeSN5fLwsHv1qibE4651elg7uArqgE04U8aOy7mJA+7GEx2XIx8Ev08aaq0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 736853858D33 Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTPS id IT7otfo2lrKrbIX1ftxGfY; Tue, 03 Dec 2024 17:49:31 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id IX1etbVdJWvXpIX1et8G6A; Tue, 03 Dec 2024 17:49:30 +0000 X-Authority-Analysis: v=2.4 cv=LtdZyWdc c=1 sm=1 tr=0 ts=674f44aa a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=RZcAm9yDv7YA:10 a=ItBw4LHWJt0A:10 a=CCpqsmhAAAAA:8 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=KfUZKJo6o7p1nXulZJQA:9 a=ul9cdbp4aOFLsgKbc677:22 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zamLtO3mnL2kZ1GcISZi5V1AkbtojKTTOCc6gz6dnAs=; b=K8UfVMvXqWgbsefjr1iIWJGK5e OyJq8/iBczOKn60O2cQoFL+JzxY9yTZwDut9jYe1e79xpAlm6MjDdfJe2uLEJdAqRE7RBvt+kw/1/ pyWVhS4LqCtjoKPbhl0bhR49O; Received: from 97-122-113-155.hlrn.qwest.net ([97.122.113.155]:32868 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tIX1d-000sz1-2j; Tue, 03 Dec 2024 10:49:29 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: restore nullptr check in compunit_symtab::find_call_site In-Reply-To: <20241203155223.10203-1-simon.marchi@efficios.com> (Simon Marchi's message of "Tue, 3 Dec 2024 10:52:18 -0500") References: <20241203155223.10203-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 03 Dec 2024 10:49:28 -0700 Message-ID: <87ser4mzbr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.113.155 X-Source-L: No X-Exim-ID: 1tIX1d-000sz1-2j X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-113-155.hlrn.qwest.net (murgatroyd) [97.122.113.155]:32868 X-Source-Auth: tom+tromey.com X-Email-Count: 15 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFnUU+afrPjhB9LT46V+f3VFdhCeQahGQ3fuhJ4qH5bqCKIwfUACqeJR8aL35sNUASd+i9jaFiuMVS29i/wK4pQWrUNkP4WtGiH/bkAQcr3YkLcae3f4 2yG6VI4GB5Ad8pfTVSXR+gkN5wzjNz1ScyQlaFLyYXx9Ad7Yr8mEbZR8R5Hoj2teE7laNlsgcsCS/YymGAPam1FWrkMAVyQsK2A= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> Commit de2b4ab50de ("Convert dwarf2_cu::call_site_htab to new hash Simon> table") removed this nullptr check for no good reason. This causes a Simon> crash if `m_call_site_htab` is not set, as shown in PR 32410. My guess Simon> is that when doing this change, I tried to make `m_call_site_htab` not a Simon> pointer, removed this check, then realized it wasn't so obvious, and Simon> forgot to re-add the check. Yeah, someday maybe symtabs should be allocated the ordinary way. On the one hand, obstacks are nice since they reduce free overhead. But on the other hand, they mean we can't use destructors... and for this case, I think there normally aren't "too many" symtabs, so it's probably fine to make the change. Simon> Change-Id: I455e00cdc0519dfb412dc7826d17a839b77aae69 Simon> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32410 This looks good to me, even obvious. Approved-By: Tom Tromey Tom