From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id H4lvO/a6m2cskR8AWB0awg (envelope-from ) for ; Thu, 30 Jan 2025 12:46:30 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ks7s8mCT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DD3931E105; Thu, 30 Jan 2025 12:46:30 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 370591E08E for ; Thu, 30 Jan 2025 12:46:30 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DABC33857BA7 for ; Thu, 30 Jan 2025 17:46:29 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 231D53858C3A for ; Thu, 30 Jan 2025 17:46:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 231D53858C3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 231D53858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738259167; cv=none; b=xYoV39GAnPR2PH2v6E0KG+Y9qgev+bGnzO+JN/LIwQ9M96T3pkxSWPos4AH4TEKcyWzvS8AR+k799ydxhQ4F5WKS3rhRKavDpVtflTniiikC2/Fu5zVpF4LKU+7DprXNnBpR2ob4V0G9vQ3apq74LnIwWxyX5ujYaGZVx3A+x68= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738259167; c=relaxed/simple; bh=VVuAu0l0g6L3hyeOr0L/xqG8Df/RmTcHyfdR8ychtDg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AsSfILBYYSEPbTkC1G1RNUuI9fWTz+XhEi9OFMGfuyrOg3jw8cFNGsNKuYJ4pyhLsKPO+QiqzCf31noX4Dpqkdpf8AlNQXV5XMhBU9wyqoeSQ00mlg9G35xwxfUyGnOHhsPeqBKiNC1Eetz/jZAyKneK1naOXZnKVEnJj+AplXM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 231D53858C3A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ks7s8mCT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738259166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BTUCrU0giRg/+T1ga5R5ePAPgQafc0W4Gpc2QJ+RBfw=; b=Ks7s8mCThk/OYoCxA1J/94Uh/R+QvybNSAqFOT2t9/R8WAYvgx46LnodnHgXN3c4Zc7RRK yBiiBH/Apdf2mrmu/pGwx/kQ9yhHNHCRp6d3t23HF3xRrfr63JdXKiXl1dxJIe9md52sb6 dhDCS/dvQlPoj5Mc2DRyMLJR94w/upE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-YBpO2VQrNvGvpGujwPWIcA-1; Thu, 30 Jan 2025 12:46:04 -0500 X-MC-Unique: YBpO2VQrNvGvpGujwPWIcA-1 X-Mimecast-MFC-AGG-ID: YBpO2VQrNvGvpGujwPWIcA Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3862a49fbdaso435349f8f.1 for ; Thu, 30 Jan 2025 09:46:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738259163; x=1738863963; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BTUCrU0giRg/+T1ga5R5ePAPgQafc0W4Gpc2QJ+RBfw=; b=NVFRWau6BGa/gIYT8SwrAmTdBRl4pvNoqMtLg01snR/eOBO/1fgeY+/41mtJaaMAw/ 2ENQRFlQZU+/2/b5N97apQub89FkL9OyJVirGPFVixOAKuaF+cgsTp1hgW7kaeMG1u/s ghL1FTz7X8ZfcC8UdcT3qnD36ozxa51VuCazdlmf5E/jqYBNaLw/KLT0X3s/CASdJNAk 5gt98dqIF95XbCT+GIVneTdR4rtw/ngW8It0IUBmo6OzoE31M/a6dCiMMaAaUFOzDVjN dzbKs2eA8qLv0059BcLlqHfOwURtVKXn3UEVw0WGcQCN9A5m22GeJ6lzwla4wv/Hsg3l s0CQ== X-Forwarded-Encrypted: i=1; AJvYcCVg1HRBNAYk/evQ9itvgE8NqMkN50Jj399Z/iViLmatY9gfXboMoyDejDFVEGZ8tho/WcU+ssKCFAAO8w==@sourceware.org X-Gm-Message-State: AOJu0YxUTxehLRBhiHaHjZRozIPBI8Tu7HA1mCH1OVyyb+yhqso3ZR3a SkTpmvBtv66RSFOe3mtZ3iXmfgrtK6pCT9xMw7xXFdbuokDYSUs7ir/FQ5htBxjJ3+EMtjxRNVw tC7ImGI06eJIACXbmRBVr5Q3ck+VbPRMYcaWL13D4/RnEtYBqzbKfl4kn3+U= X-Gm-Gg: ASbGncs3mixPPqZ/XTazw6mUKCPOFlxANkqs4ND2L5w2mJOhkS/zZpC561zHUHpHRDj Aat4tysqw/04STPJ1IXrkc9AuMrubfd/UqzSG2iGNqFD392GpXxdI4L21n+FczzXBJt1rdI5TR3 vfq3gZdaBk70MkxNYh1nFTTzgcRyvNuCB2Dj9YHmWp+SNhYr76Rwe16rmBb/LMLvXjZ7/LBalE3 EH6+8w8YLYph2BkiNG7q5xgduFx4qi/9RD1uJEQBK/IwCCbv54eHlpgxOLpivSwMCo7GCYRRrI3 0T2CeYV4Zf94KX8+3rgaSpl2346yVw== X-Received: by 2002:a5d:5f4a:0:b0:385:df84:8496 with SMTP id ffacd0b85a97d-38c5194ca26mr7576534f8f.3.1738259163594; Thu, 30 Jan 2025 09:46:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IEJxJdovuVhFQRBqFX+jYnelZtGuWC7KpxoMN3jWuyCzooKbRwl0CUfZp+XoqhoiR1Kv3r5sQ== X-Received: by 2002:a5d:5f4a:0:b0:385:df84:8496 with SMTP id ffacd0b85a97d-38c5194ca26mr7576509f8f.3.1738259163259; Thu, 30 Jan 2025 09:46:03 -0800 (PST) Received: from localhost (44.226.159.143.dyn.plus.net. [143.159.226.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c1d1d03sm2650178f8f.99.2025.01.30.09.46.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2025 09:46:03 -0800 (PST) From: Andrew Burgess To: Kevin Buettner , gdb-patches@sourceware.org Cc: pedro@palves.net, Kevin Buettner Subject: Re: [PATCH v5 0/4] Make linux checkpoints work with multiple inferiors In-Reply-To: <20241210020313.584564-1-kevinb@redhat.com> References: <20241210020313.584564-1-kevinb@redhat.com> Date: Thu, 30 Jan 2025 17:46:02 +0000 Message-ID: <87sep06vqd.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jmYBEY1bIxcOgq1s6k4E-QBIoEkffDqbhc8NyfUXZ8o_1738259164 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Kevin Buettner writes: > This series fixes some problems with the current checkpoint code. The > first patch makes the checkpoint code inferior aware, fixing a number > of bugs. The second and third patches are largely cosmetic - they > make changes to checkpoint related output. The fourth patch updates > the documentation. I had some specific comments for patch #1. But I've looked through all the patches in this series, and they look good. Approved-By: Andrew Burgess Thanks, Andrew > > The v2 series incorporated Pedro's suggestions regarding the > numbering of checkpoint ids. See the first patch for details. The > tests have been revised to account for these changes and new tests > have been added as well. > > The v3 series split out a cosmetic change from the first patch. It > capitalized the output of a successful checkpoint command. This was > prompted by the Linaro regression tester, which, due to the > capitalization change, found two regressions in > gdb.base/kill-during-detach.exp. (I had made a mistake during my own > testing causing this to not be caught.) > > The v4 series addressed Pedro's concerns from his review of the v3 > series. It also adds a NEWS entry and updates the GDB manual with > regard to checkpoint identifiers. > > This v5 series makes several changes to the output for the > "info checkpoints" command. As a consequence, both checkpoint related > tests as well as the documentation were adjusted for these changes. > > Kevin Buettner (4): > Make linux checkpoints work with multiple inferiors > Capitalize output of successful checkpoint command > Print only process ptids from linux-fork.c > Linux checkpoints: Update NEWS and gdb.texinfo regarding multiple > inferiors > > gdb/NEWS | 2 + > gdb/doc/gdb.texinfo | 20 +- > gdb/linux-fork.c | 590 +++++++++---- > gdb/linux-fork.h | 15 +- > gdb/linux-nat.c | 18 +- > gdb/testsuite/gdb.base/checkpoint.exp | 26 +- > gdb/testsuite/gdb.base/kill-during-detach.exp | 2 +- > gdb/testsuite/gdb.multi/checkpoint-multi.exp | 800 ++++++++++++++++++ > 8 files changed, 1277 insertions(+), 196 deletions(-) > create mode 100644 gdb/testsuite/gdb.multi/checkpoint-multi.exp > > -- > 2.46.2