From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id U75oLA3msWjHdQ8AWB0awg (envelope-from ) for ; Fri, 29 Aug 2025 13:40:29 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=GQQWPbc9; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A058E1E04C; Fri, 29 Aug 2025 13:40:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C060A1E023 for ; Fri, 29 Aug 2025 13:40:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20B903858286 for ; Fri, 29 Aug 2025 17:40:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20B903858286 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=GQQWPbc9 Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 089B23858287 for ; Fri, 29 Aug 2025 17:39:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 089B23858287 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 089B23858287 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756489195; cv=none; b=SUjvI3YCJ+LtO8dZUANYEfACtfx1HpDyQtF/yRCpgufSZFMFOulC9LCfU9W4od/u3a9fwbQcTqpa8fpRB9SMMGhHLTbaSdRQsfNCvl0KbF0moC1dhwQ+byY22hykUMVyrfBGRDK54JFbN/IWi1/hywwQI5luOPJaaac7m9+lfCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756489195; c=relaxed/simple; bh=4mUHBgdHnaqu8iXGuUzO+WQWSN5W+ANPRCI5Y5hvB1k=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=tgVY8fIGxrPA7lWHmZKwJ2q5oGH4UOEVd7K/tq1e0KnhZT0gZtfVKTI/eYTY6MOmCDAMyLK1rXpkD7ipn4Utc50itFHU/24WUBEaShqkSr7e3dH1OM7aBWfND1/L/zfMvQcu2+EhzqIhliHwTIigu1egSYSiwVQ0KLFri2mpDog= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 089B23858287 Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id s0ZTuvfSvYhwls34ruZyeW; Fri, 29 Aug 2025 17:39:53 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id s34qunY0RGGDls34ruHlfQ; Fri, 29 Aug 2025 17:39:53 +0000 X-Authority-Analysis: v=2.4 cv=XN0wSRhE c=1 sm=1 tr=0 ts=68b1e5e9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=2OwXVqhp2XgA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=pd9CayHTpDF8tAlz7u8A:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZJ8Dgmbx6NRnF4bc/af9iaOHap8jZ9xUry/09G5wE9w=; b=GQQWPbc9P+bHb5exE/pbYPOGWB iaFAb3exX0utsm4E3qW+42Vui/VjrpZems8kVDhX1ZRncsArskRzJViDumIZDImAvtlXqU6l+6h1+ SXPL+Enq0D2F+I/9XVEyF+BSQ; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:47012 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1us34q-00000003EGa-2gG0; Fri, 29 Aug 2025 11:39:52 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdbsupport: make filtered_iterator work with pointers In-Reply-To: (Simon Marchi's message of "Fri, 29 Aug 2025 12:00:56 -0400") References: <20250828151100.84594-1-simon.marchi@efficios.com> <20250828151100.84594-2-simon.marchi@efficios.com> <875xe6utyx.fsf@tromey.com> X-Attribution: Tom Date: Fri, 29 Aug 2025 11:39:51 -0600 Message-ID: <87sehat4bc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1us34q-00000003EGa-2gG0 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:47012 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJig+3SGg7kV9dWi1WUK4PvYfqSZa+D6mGkHNM7K9Y9TEDSmP2oMIQMk8S4NRBTAcRAvvjSmzLEh8ToXp7x+Srtl1uIFk4/CnBwhxR3rbTKSIpendvHi v6ZX3/gnusVEzejsKtydVqm2diTTF/mLbEpolLlAGvFR5x3z5Z+z8ulafEKJ5MzOJYZN3PGQXQqocOgIk/CnHG8Kut38yl1qCxM= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: >> I also wonder what this constructor is even needed for since it seems >> like a filtered iterator should just wrap an ordinary one anyway. Simon> I think it's just a shortcut to have less boilerplate when you need to Simon> instantiate a filtered_iterator. I think I would prefer having just the Simon> begin/end version, so that there is less magic involved, making it Simon> easier to debug compilation errors, at the expense of having to be more Simon> explicit at the call sites. I think I tried it in a previous iteration Simon> of this series and gave up, but if you think it's a good idea, I can try Simon> it again. I think you should go ahead, we can try to remove the template constructor after. Approved-By: Tom Tromey Tom