Re: [PATCHv2 3/3] gdb/python: add Corefile.mapped_files method

Tom de Vries
2025-10-08T15:44:32Z

On 10/8/25 16:14, Andrew Burgess wrote:
> Let me know what you think.

Hi Andrew,

thanks, this LGTM.

Please apply this as well:
...
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 5dfcfefd7c1..ef6a8f859ef 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -11635,7 +11635,7 @@ proc expect_build_id_in_core_file { filename }
{
}

# Convert OFFSET to decimal.
- set offset [expr 0x$offset + 0]
+ set offset [expr {[subst 0x$offset]}]

# Now figure out the page size. This should be fine for Linux
# hosts, see the istarget check above.
@@ -11650,7 +11650,7 @@ proc expect_build_id_in_core_file { filename }
{
# but the default behaviour is to include the first page of the
# ELF, so for now, we just assume this is on.
verbose -log "Page size is $page_size, Offset is $offset"
- return [expr $offset < $page_size]
+ return [expr {$offset < $page_size}]
}

# Return 1 if the compiler supports __builtin_trap, else return 0.
...
to fix tclint warnings.

Thanks,
- Tom