Re: [PATCH 2/3] gdb: make structured core file mappings processing global

Tom Tromey
2025-09-16T17:28:54Z

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> This commit renames 'struct mapped_file' to 'struct core_mapped_file'
Andrew> and moves the struct into gdbcore.h. Then a new global function
Andrew> gdb_read_core_file_mappings is created into which I move the code to
Andrew> build the structured data.

Andrew> Then corelow.c is updated to call gdb_read_core_file_mappings.

Andrew> This commit does not extend the Python API, that is for the next
Andrew> commit.

Andrew> There should be no user visible changes after this commit.

Looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>

Tom