From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id R6t6DrMdCWkY9R0AWB0awg (envelope-from ) for ; Mon, 03 Nov 2025 16:25:07 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=YGZocy2s; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2BBC31E04C; Mon, 03 Nov 2025 16:25:07 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A91FB1E04C for ; Mon, 03 Nov 2025 16:25:06 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 352743858427 for ; Mon, 3 Nov 2025 21:25:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 352743858427 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=YGZocy2s Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 462393858434 for ; Mon, 3 Nov 2025 21:22:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 462393858434 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 462393858434 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762204959; cv=none; b=Vc9sqXXkNybBEXH4I2501v7JcYY517EIAKgaFiUEZ6INQhWIc6GjpDmGgaDXTR1b+8FEW7A8Tj3KB4wAfDP/3qabjaZIFkCB6SDB4izInxmJ26o/AHVaE+ZcNP+1ETmIkrbVDS468+KeORRhyuc1RDjqcmfngZn3RovOpoX7Gpc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762204959; c=relaxed/simple; bh=xpN1YtBfKqO8xZcgZT0AMCdv2D7ZD/U5GvYevcviqkA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cRtv1upyxawILsuPhcUSoo5cJCJF67pMtjNh9hkjbo+GaN3diSJ8fLP36n4ufp6GLLHwKO5eW0AXqDTLrzZAvuGJr73NkUoaXRS1+jZHoaQfzapJjrP+2oDKj4XGxXYsf7utw/s8CHhU2Cs9ABidLYzTX0YkECyYdGW9l5m7XVg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 462393858434 Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id FwyUvnGUIv724G20cvglRB; Mon, 03 Nov 2025 21:22:38 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id G20bv5p9je5vdG20cvT9N4; Mon, 03 Nov 2025 21:22:38 +0000 X-Authority-Analysis: v=2.4 cv=PI0P+eqC c=1 sm=1 tr=0 ts=69091d1e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=6UeiqGixMTsA:10 a=ItBw4LHWJt0A:10 a=ZysoHL1CAAAA:8 a=Ypm8R_3Xya051pIAQl8A:9 a=5AXFdVBGJ8Jq6-3WnMNo:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LnOJIMWw8oT5VEefD34E4aA3YknwjRM4Q2Xav9Fo/e4=; b=YGZocy2sVj9mFa3Wkc5jx12lBx wymRtLetVTEZOnAm5VTLbv2Y8AF0rgav4pLnfeMfFLHWR1YZ2mSzJk5r1Z29owrRWnDBcA8YLU5ur DAnIVT9m2SSi2KjmWBb/LhgHu; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:50592 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vG20b-00000000nlm-2WIX; Mon, 03 Nov 2025 14:22:37 -0700 From: Tom Tromey To: Sven Schnelle Cc: gdb-patches@sourceware.org, Helge Deller , John David Anglin , binutils@sourceware.org Subject: Re: [PATCH RESEND] gdb/hppa: guess g packet size In-Reply-To: <20251101080538.857188-1-svens@stackframe.org> (Sven Schnelle's message of "Sat, 1 Nov 2025 09:05:38 +0100") References: <20251101080538.857188-1-svens@stackframe.org> X-Attribution: Tom Date: Mon, 03 Nov 2025 14:22:36 -0700 Message-ID: <87seeuak0z.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vG20b-00000000nlm-2WIX X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:50592 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJiNt3hUAR8Kfe3M2a0n+JcJ8KY5/tdxuZNXMBrO13XfpGMmxLAaRqddfwXpTHz4OmqVevTE4xcmKUjiJe066B569zu5HKHmeE+y5klSZCILE9olua16 nbbdsnh12gjmDF6MHZu/WvFAdErm5rwtm1JoAiV/FV71RcASJdGlBG1gFuQJi3GG/5L3H5LIh/c1LHV621yPpsJgdlzTC8NIQ3M= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Sven" == Sven Schnelle writes: Sven> With qemu supporting 64 bit now, add some code to determine the Sven> register size of a hppa remote target. Thanks for the patch. Sven> +struct target_desc *hppa_tdesc32; Sven> +struct target_desc *hppa_tdesc64; These should be 'static'. They can also just be objects, not pointers, I think. Sven> + /* Determine from the target description if we are dealing with Sven> + a 32 or 64 bits architecture. If the target description is not Sven> + available, then check whether bfd_arch_info could be used. Sven> + Otherwise default to a 32bit machine. Sven> + */ Sven> + if (info.target_desc != NULL) { Sven> + if (tdesc_property (info.target_desc, PROPERTY_GP64) != NULL) Sven> + tdep->bytes_per_address = 8; Sven> + else if (tdesc_property (info.target_desc, PROPERTY_GP32) != NULL) Sven> + tdep->bytes_per_address = 4; Sven> + } else if (info.bfd_arch_info != NULL) { There's a few coding style issues here. Use 'nullptr' not 'NULL'. And the braces are in the wrong spots -- see other code in gdb or the GNU coding standards for where to put them. Sven> + } else { Sven> + tdep->bytes_per_address = 4; Sven> + } Also single statements like this don't need braces, there were a couple of instances of this. Sven> + hppa_tdesc32 = allocate_target_description ().release (); Sven> + set_tdesc_property (hppa_tdesc32, PROPERTY_GP32, ""); Sven> + Sven> + hppa_tdesc64 = allocate_target_description ().release (); Sven> + set_tdesc_property (hppa_tdesc64, PROPERTY_GP64, ""); The reason I suggested using objects and not pointers is that, although we do have a number of calls to .release() in gdb, we somewhat try to avoid them. thanks, Tom