From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VJxTLkaRMGkpUhYAWB0awg (envelope-from ) for ; Wed, 03 Dec 2025 14:36:38 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=uWhbb+wK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id ABA2B1E08D; Wed, 03 Dec 2025 14:36:38 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0304A1E08D for ; Wed, 03 Dec 2025 14:36:38 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 81E504143B25 for ; Wed, 3 Dec 2025 19:36:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 81E504143B25 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=uWhbb+wK Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 1F3034143B03 for ; Wed, 3 Dec 2025 19:36:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F3034143B03 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F3034143B03 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764790571; cv=none; b=Hy8doZ1KNSIXhL12P37DvGbvBqeryHJDwJYeeDFocK9q6L9cv4s+Uc8wNHhtg6xHAoovoCTko6o8xy5c7JKS1Kf7KbLdjTEs/em9EY7FbX5YOSAr86x0SpaYsAxTWcRRMIBihf4xbLiJZSuhgs51+W3RxNQfVt/5+t/HfgS/8TU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764790571; c=relaxed/simple; bh=NSVNUz12PgaTpH9mPEgo24tVhVPthcYv4YDE5lI6Bew=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qnsgc7xNPzIYwdA7lP6/oS403gREcjz0FTGc0+oAHhjGjczjS5sWgFW8brJgstW1JxgIs5m0IM+a1rilcuyZ/90hROGGnPVCuGIjsRq7C8VMDXuMczAriR8KDQ62sfgfUWCvrdfr8NYyWPhAr15gfcDWuV6WKIjHvkUR315H958= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F3034143B03 Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id Qr2mvSI6kv724Qse2vZzZe; Wed, 03 Dec 2025 19:36:10 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Qse2vZtmK2l0kQse2vKZpE; Wed, 03 Dec 2025 19:36:10 +0000 X-Authority-Analysis: v=2.4 cv=UfRRSLSN c=1 sm=1 tr=0 ts=6930912a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=ItBw4LHWJt0A:10 a=TDl5R864AAAA:8 a=N1QSuCvAufv9jJLRQCsA:9 a=QEXdDO2ut3YA:10 a=4IKI_MBedZsHOhguCAbN:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=63EBl2H1Njs6CPNPvalLXJUcRj9dl+rErCuYkpPC+3I=; b=uWhbb+wKGAqwJb1PjDdB72NEwE 0ngr0msrR/jcbGFqfwKB9LXcbaor9/YL2nV0l77MwMv8ZcpVygucxAdCUkF8MHw0Y5odx8gc6vwGb j8qYqYyJTDdF3j4z4TsI7O8yE; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:39140 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vQse1-00000003JD5-3mVU; Wed, 03 Dec 2025 12:36:10 -0700 From: Tom Tromey To: Jan =?utf-8?Q?Vran=C3=BD?= Cc: "tom@tromey.com" , "gdb-patches@sourceware.org" , "simon.marchi@efficios.com" Subject: Re: [pushed] gdb: change blockvector::contains() to handle blockvectors with "holes" In-Reply-To: ("Jan =?utf-8?Q?Vran=C3=BD=22's?= message of "Tue, 2 Dec 2025 21:58:38 +0000") References: <20251128134950.1763596-1-jan.vrany@labware.com> <20251128134950.1763596-2-jan.vrany@labware.com> <87ecpc93xk.fsf@tromey.com> X-Attribution: Tom Date: Wed, 03 Dec 2025 12:36:08 -0700 Message-ID: <87sedr73yv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vQse1-00000003JD5-3mVU X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:39140 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfL2IPFOYQao4BLW5D0Gp3aM8EKbwMjXvQD+9Pu6VIJGoHfHK0BQmmjwAv98ILqCNbWzOzaPfaaniJ3m6SKvtCUH8H8hoY87yAX3XWWpd4d0HtK6voQ3N UF0JA5sZLq0QRVwapmUnEU33jC0KNhOl97oY7c3bhTylhsRgUUOPxcrOHOaGHNEOXlwD+cn+rO1if92sPuu4DFiyKDGBadImI0k= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Jan" =3D=3D Jan Vran=C3=BD writes: >> FWIW it seems to me that the blockvector should just have a single >> lookup function, and it should be used to find precisely the code block >> containing the given address.=C2=A0 That is, it should never return the >> static or global block, since those aren't really "code" but instead >> just containing scopes.=C2=A0 This is the direction I was trying to head= by >> removing calls to map(); the one remaining call is one of these weird >> ones... Jan> I agree, I just do not really understand why there was the Jan> difference in first place. I don't really, either. That code is pretty old, though, and some of the older code is pretty questionable. Like sometimes problems with debug readers were worked around in core code rather than being solved in the reader, abstractions were very leaky (or in this case nonexistent), etc. Jan> In fact, it seems that it matters - I've got a report that this Jan> commit caused regression on arm (still investigating, I do not have Jan> armhf system at hand, so need to set it up first). My current attempt at cleanups here also run into some regressions that I wasn't really expecting :( Anyway I'd find it interesting to learn what the ARM regression is about. Tom