From: Tom Tromey <tom@tromey.com>
To: simon.marchi@polymtl.ca
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb, gdbsupport, gdbserver: add support for printf 't' length modifier
Date: Thu, 15 Jan 2026 12:24:28 -0700 [thread overview]
Message-ID: <87sec6el1v.fsf@tromey.com> (raw)
In-Reply-To: <20260112182407.622150-1-simon.marchi@polymtl.ca> (simon marchi's message of "Mon, 12 Jan 2026 13:24:02 -0500")
>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
Simon> Add support for the `t` length modifier in format_pieces, which
Simon> gdb_printf ultimately uses (through ui_out::vmessage). Modify the three
Simon> users of format_pieces: gdb's printf command, gdb's ui_out::vmessage
Simon> function and gdbserver's ax_printf function.
Thanks.
These modifiers are one of the clearest reasons that printf should be
replaced. I think we should generally avoid them. We've already got
plongest, etc; which seem safer. See commit a1537331 (the "other
direction") but there's also commit a5adb8f3 and probably more.
Anyway, it's ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2026-01-15 19:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 18:24 simon.marchi
2026-01-15 19:24 ` Tom Tromey [this message]
2026-01-15 19:36 ` Simon Marchi
2026-01-15 19:42 ` Tom Tromey
2026-01-19 17:29 ` Guinevere Larsen
2026-01-19 18:09 ` Simon Marchi
2026-01-20 12:29 ` Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sec6el1v.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox