From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YWreJFT0cGl2Uw4AWB0awg (envelope-from ) for ; Wed, 21 Jan 2026 10:44:20 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=L744PuIJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 934B11E08D; Wed, 21 Jan 2026 10:44:20 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 439A61E08D for ; Wed, 21 Jan 2026 10:44:20 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id AF3B14BA2E2E for ; Wed, 21 Jan 2026 15:44:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF3B14BA2E2E Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=L744PuIJ Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 10F284BA23C4 for ; Wed, 21 Jan 2026 15:43:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 10F284BA23C4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 10F284BA23C4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769010234; cv=none; b=OwK72iKvbTQAGxiwYbr/opeRriHlc0CYmj3Mo6Stdybs/zTqb7sFKwVaxkcpg2aOCxWUOMm4RIRhnMcgCMGivn5/KTRYw0IY88RO2Sph5NwQL830ZrykBLckH1sIz1TLmpjP72UrSgJfN8LCBENjRNDnaDKxW+qe/twhG4BI5rY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769010234; c=relaxed/simple; bh=0bCtc9Pjelvde4YIawcsXId5LO8e7RTRxC2zwdj58Cw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WEgFYhnjkhkdg5IXE6Yuo7S44dFf36lFvxiHpIqD28Px+8iyHJDElMptYs/MyD2eWr5u23MFGhK2i6+Xi0+3iSXy6o361HoFT7Jg6KxWD9+cPlCZ+PTWApGjVyMIYujtQtJ3hV0PNN9DBZvxdT1uake6L7zIY5ap1/BxPv4vb78= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10F284BA23C4 Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id iYWBvJFfMSkcfiaN7vAtFr; Wed, 21 Jan 2026 15:43:53 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id iaN7vURHcjAxuiaN7vyUrv; Wed, 21 Jan 2026 15:43:53 +0000 X-Authority-Analysis: v=2.4 cv=EoDSrTcA c=1 sm=1 tr=0 ts=6970f439 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=0ebSg_e0fwkcd--1d8YA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wiXA4YrVco+w8MR/p2ksb8NLO/Bdz2vm0n9RZAVAUvM=; b=L744PuIJOSSou8v3GrAYzUZZjH Uty/yisCH2GITazjRIZuMg/GYLWcYgEaaoG0SJUnHl3u857nCmkxKCzCy+eMWr940Z2FkKHpUAbX4 kecffXF6mesN07/Fm4AG8Jmsq; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:58526 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1viaN6-00000004OSj-3jks; Wed, 21 Jan 2026 08:43:52 -0700 From: Tom Tromey To: "Schimpe, Christina" Cc: Hannes Domani , "gdb-patches@sourceware.org" , Tom Tromey Subject: Re: [PATCH v2 08/11] Move software breakpoint recognition code into x86-windows-nat.c In-Reply-To: (Christina Schimpe's message of "Mon, 19 Jan 2026 12:51:48 +0000") References: <20260117134052.2660009-1-ssbssa@yahoo.de> <20260117134052.2660009-8-ssbssa@yahoo.de> X-Attribution: Tom Date: Wed, 21 Jan 2026 08:43:51 -0700 Message-ID: <87sebz7yyw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1viaN6-00000004OSj-3jks X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net (bapiya) [97.122.114.32]:58526 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFAk5kJxVQc2/F78mGOl4mE2PReMXCtogpbxS5jKCBFOyXaiRvHsrpsRud4eq3EGXkqQB8yNd1yAY/da9lrTRZ4VqGrGR6jgfZq8BOyKOGoO3nFIfsgQ t05Hu8gQxD3k5LOEpCNF2Q3T0OHP11LwyfmbPnU4HnCf0AEk9kM+49Tfc9qWxg8xZX41mk2tulm9SKN9lyYDxghZ8vJXi1EP2ZI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Schimpe, Christina writes: >> + is_sw_breakpoint (EXCEPTION_RECORD *er) = 0; > Nit: Shouldn't this better be "const EXCEPTION_RECORD *er" ? I guess if we're doing that we should consider is_sw_breakpoint (const EXCEPTION_RECORD *er) const = 0; since presumably this method isn't mutating *this. Tom