From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +7TXDP4FgmkN+yUAWB0awg (envelope-from ) for ; Tue, 03 Feb 2026 09:28:14 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=e3lLhEfW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 22F611E0BA; Tue, 03 Feb 2026 09:28:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2E0D61E08D for ; Tue, 03 Feb 2026 09:28:13 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A4FEB4BA2E0D for ; Tue, 3 Feb 2026 14:28:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A4FEB4BA2E0D Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=e3lLhEfW Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id BDFCB4BA543C for ; Tue, 3 Feb 2026 14:27:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BDFCB4BA543C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BDFCB4BA543C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770128860; cv=none; b=rk1qxx+bZGPqMOlMBW2ztha2lpd3Z2NxEvYnkI92lCYbSXNGiKC8eReoyBoZL26FxRhgXFYQIDk03Zx4xK3O9i9R3g43QH1zw/fPSzHWCb5p+ktG21gy3i81FbqSijsjYQLIARW89QjM5W+H1BY7TPDbq0nsjGo8Ob01k3VDhZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770128860; c=relaxed/simple; bh=btVlyS8/dcdUbHrf8rHfaDNLv9V0ZwCuvm2VhLVUvBA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=P9bpJ8l1mwmS2emyDLpYylujC8aj4uiApyTsph9zAOcnKTB5tJYWcPjUrt0TBBdo3yOSuLlw0FktMrvJugP04dmgSOC2lyW9CKkH2h7i4V+KdsKVAHJhVBSP7/xdWsl26hTE5OSEIDK9YuIM/1HHkoYA/OCkLeKGO2+LfKYlZqI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BDFCB4BA543C Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id nGjSvd05DKXDJnHNUv1ml8; Tue, 03 Feb 2026 14:27:40 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id nHNTvGHyBOs9RnHNUvRD4b; Tue, 03 Feb 2026 14:27:40 +0000 X-Authority-Analysis: v=2.4 cv=HPPDFptv c=1 sm=1 tr=0 ts=698205dc a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=HzLeVaNsDn8A:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=-TgpxQuZUK-bE0X6NxkA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1CIVL5XxxDP3im2xWa2rEbv0PfxR7jxTV4M5HNTyCsc=; b=e3lLhEfWeanXgq9A67CGeEmLDT AIb1yepxyeuf/yQzZYvIYQEQZrR38ojK2FpT8q/+RyNIpoG2XG3+vWPCDkO4y9MvSCyTbiJePSItG frf7bTq/9Ulp+x0rXXXqi3gMm; Received: from 97-118-49-200.hlrn.qwest.net ([97.118.49.200]:47700 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vnHNT-00000002UW5-2nPJ; Tue, 03 Feb 2026 07:27:39 -0700 From: Tom Tromey To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: fix filename matching in skiplist_entry::do_skip_gfile_p In-Reply-To: <20260202203404.708144-1-guinevere@redhat.com> (Guinevere Larsen's message of "Mon, 2 Feb 2026 17:34:04 -0300") References: <20260202203404.708144-1-guinevere@redhat.com> X-Attribution: Tom Date: Tue, 03 Feb 2026 07:27:38 -0700 Message-ID: <87sebh7vhh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.49.200 X-Source-L: No X-Exim-ID: 1vnHNT-00000002UW5-2nPJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-49-200.hlrn.qwest.net (bapiya) [97.118.49.200]:47700 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIweB/JX3cjI+0bvJsFDvomw5VqhjkCoCoPyo9FZldjeqzMtjiKeJafyhb5EtMhr66NUASMOHsCkkt+d3HrOeCo4jdKm/vjJiygEM76lHDAzZ3RV0LTf TbqB3Fw/88DktxSAjB8AO1PiOhFiIjF327blOoVkuzgl/E7mIHczAwsmhaVLBC9QpQ4e3rpvoh64Bmnbi5Kw3UNoNzUhtzYvTuM= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Guinevere" == Guinevere Larsen writes: Guinevere> - result = gdb_filename_fnmatch (m_file.c_str (), fullname, FNM_NOESCAPE); Guinevere> + result = gdb_filename_fnmatch (m_file.c_str (), fullname, FNM_NOESCAPE) Guinevere> + == 0; Wrapped expressions like this need the RHS parenthesized. thanks, Tom