From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6bDlF2GGqGmTaBQAWB0awg (envelope-from ) for ; Wed, 04 Mar 2026 14:22:09 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Q7zlx2uj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5D30D1E0DD; Wed, 04 Mar 2026 14:22:09 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BEC431E089 for ; Wed, 04 Mar 2026 14:22:08 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 644EE4BA2E18 for ; Wed, 4 Mar 2026 19:22:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 644EE4BA2E18 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Q7zlx2uj Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 080224BA2E0D for ; Wed, 4 Mar 2026 19:21:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 080224BA2E0D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 080224BA2E0D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772652097; cv=none; b=QhYlnnFtmmyX1xsKYQzLkgmLOP0t+hJEDAXTKvzktf5WmF5k+mK35BnrbJC8VjGfVCwHvGX8vr0VUtn9CkYZtMRHhr9E06xMtjnvrY7BaSbeDLtuQYKDBkJEz0TueORg3abPFd7colJGyqufnaihUTFKxrNAewDBKfw0PkxS9Ps= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772652097; c=relaxed/simple; bh=8tFT0RxFnZgPNO0+EvqTAHXSR+LNQvYEDUF3HeBw4i4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=STKR+kkHLNUnI4eru27Bup5DZAGlDoywpUh0/YQ+QRjzUAoLkLLi73BnBBzGs7EQhJjaAnv9HuGOzvvg9Xp6QjN/R0TLpG29BLZfwAgdUoYV6Q7oOUfY6ZhjXTK6VF8ExPLXJ+LivG2X1d+MG9AcpJFMKsCsssnOjDkVjyeF8hs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 080224BA2E0D Received: from eig-obgw-6004b.ext.cloudfilter.net ([10.0.30.210]) by cmsmtp with ESMTPS id xqxOvKP0UKjfoxrmpvf9rf; Wed, 04 Mar 2026 19:21:35 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xrmovfx7QK8vzxrmpvro0I; Wed, 04 Mar 2026 19:21:35 +0000 X-Authority-Analysis: v=2.4 cv=cJDgskeN c=1 sm=1 tr=0 ts=69a8863f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=45GcOuuJ2vJnx8qOzYYA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KHsnNxk1TLX/VRsUVq/bw1nFNh++Hh8uEpNETznoq94=; b=Q7zlx2ujvbO6GCg9G+101Fdd+R vXNO6TJtKZwW7UO9GSfWMZubnvpoBXl8RfQ5OlscgaxiB9bc1O3BTeQzd5nJ1vc+EHNwb9DLQd/Ee AY/6WeHjNbsIlXgdEu3ZDhsb4; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:51372 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vxrmo-00000001yzm-2KmU; Wed, 04 Mar 2026 12:21:34 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH v3 7/9] gdb: make expanded_symbols_functions hold compunit symtabs In-Reply-To: <20260228035425.422765-8-simon.marchi@efficios.com> (Simon Marchi's message of "Fri, 27 Feb 2026 22:51:54 -0500") References: <20260217195329.3833518-1-simon.marchi@polymtl.ca> <20260228035425.422765-1-simon.marchi@efficios.com> <20260228035425.422765-8-simon.marchi@efficios.com> X-Attribution: Tom Date: Wed, 04 Mar 2026 12:21:33 -0700 Message-ID: <87seafo0xu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1vxrmo-00000001yzm-2KmU X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:51372 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfM7Ggn9pEKLCluU1263LZNOYwyza85xFJXQdoBaAcLI1WUZ2ZxgHVcnleksWYmfhnNC++xwWbDgGPeo2MkpaQS+5wAzZkVhF99L8RsFTW57XCGvhoUE5 8wtrmrrOQqbCHjQVtgz6fNtKJyXyloh0MiNyMpZFqhFAXFpdY00sqg2QU0YRbk0dso6ik2qIMjG2PqR0T35wZlmMrBSwfKHu8Ag= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> Change the expanded_symbols_functions quick functions type to hold and Simon> use a list of compunit symtab to search. Simon> Right now the sole user of expanded_symbols_functions is JIT. Update it Simon> to keep a vector of compunits as they are finalized, and pass this Simon> vector to the expanded_symbols_functions object. I think this is a good direction but this patch isn't quite complete. The issue is that there are still a handful of spots in gdb that loop over all compunits. But with this change, these spots will skip some compunits. Now, arguably some of these spots aren't really needed in the current setup. For instance, objfile relocation in practice is probably not needed by the current expanded-symbols users (though it seems a little less future-proof to assume this). OTOH some of the spots should still work, e.g., is_addr_in_objfile or the symbol-searching code (... which should be changed of course, but currently hasn't been). Tom