From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id B8HUCR4/T2qrRy0AWB0awg (envelope-from ) for ; Thu, 09 Jul 2026 02:26:38 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=upy/Eziw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 12C0C1E098; Thu, 09 Jul 2026 02:26:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F0D901E04F for ; Thu, 09 Jul 2026 02:26:36 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F2EBE4BA2E26 for ; Thu, 9 Jul 2026 06:26:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F2EBE4BA2E26 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=upy/Eziw Received: from mail-yx1-xb135.google.com (mail-yx1-xb135.google.com [IPv6:2607:f8b0:4864:20::b135]) by sourceware.org (Postfix) with ESMTPS id C519F4BA2E0B for ; Thu, 9 Jul 2026 06:26:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C519F4BA2E0B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C519F4BA2E0B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b135 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783578369; cv=none; b=JkvGVC4aNOSE5fvaM3WIfhLaUK9cQAq2vCnBglfvHUsThozzNiued+hF6yomKpZM5bYLhz7PVoCTFJtq4PuxUTcrD7jLfoUCCfDfJ96uc7OgWCYZAjxMXk4w4g/Llj5tUqJwor1VgyF7yt1k2bc7P1tug8tsc1lBZkTJdhjGyCc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783578369; c=relaxed/simple; bh=MirMnTojU7gk5g39jTzB1Yhsdx/zYVYey4w5wRPPV4k=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=tpm/VGddolierZfj6wWiD/zdLb46umhl8q4NNTTHRwGdcEQ745mTevTUsZCk2frsuC4EkNScKnKg1VfJfuTjJTIeYf6wNTbt75qsIQRsb0cGv+nwqbv5z/UkZKOzauuN77XzfSJDLTsQ9lS9RcjpTtalRCy6zSwiBlqeee25zrY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=upy/Eziw DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C519F4BA2E0B Received: by mail-yx1-xb135.google.com with SMTP id 956f58d0204a3-664b3831a20so810344d50.3 for ; Wed, 08 Jul 2026 23:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1783578369; x=1784183169; darn=sourceware.org; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=FHJlpmomnOonHZway/JCGHdB8E7Z0fDcQwloq/HB1dc=; b=upy/Eziw3KtYXAO2ijLDmA4IzqkaXXzQ7XK7PEfVDmcc4q2OzB9DpGdZJfAg/f6Kfp XWvIyOUuLry+Qo63b0agEmbM7iULOn9qJyRlu3k7AlTkj2VdXIuAKS7vKi2vjWX0bRFS +AYXeEQlBwHIz9R2Gu1s0sXwcxVakgDC61eggwEGp9APStnbHYBH+TttTzG9o5gTnWJ5 ErkWZJWVhnPdP7vIe4nFGGpz7lnYB8cPLvxlS5BaWrkj5bac2gOY2VWpy8qvtbSy10kw aRqNKLDyl4FQ927gi0FzTaxGGaCx8de/ewnk2nKPzL36P+1mJ/awU0zeRhiNEZAevfoJ ww5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783578369; x=1784183169; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=FHJlpmomnOonHZway/JCGHdB8E7Z0fDcQwloq/HB1dc=; b=CInuHRLFI21oIzcPJHg/8FHVNTtxZLNxedRJjWWQdvkajkA19KukOw4MY+kqXSjbdH RnghOOtKGfVXmPawvzPVv0ih5HFTRWrmBkwoDKqzfkM7/8mmxmVamiJ5QSXiYpUVdHDa lSd6Z+QLP50dmoyL67Cv6iKtndgh9R1AJ9iE92bbVBVKK0IabIh7r50zU5HFsCY6VcrP v1CR3s5sCXAnLPGEyy26vr+ROR/n2e4UQb+6JE9RlcMXTuJ8RWv7yKIwAcesAQX0c2SI bOR8g9VKiROL1Q4Vk9Se/GGGyMLb12TG4fPyLb3XW6e6B93pmM/GEptP3rb2SbB6JXPJ LRKA== X-Gm-Message-State: AOJu0YwT5H5+2QvjYQKVSCUU28zJQnKL82xyDRlbAscFgfL7yfI/+Dq0 xWA1OoZth3n7BgZitvNSIReBr4FaPJN/RoX5NAQOCEOhIG4htgjU2dj1GxOUitJQL/A= X-Gm-Gg: AfdE7cl45kHCfjq7IZtegr0DZXBFgrpltZszwyngbdSHzBCKJUhM+57Wka0sXXRDVHt lKFU28bTeY3SLOIncQkALMPnu5DRK+9vy6c+ScFAo6As/r+NMGpCFxPAoRvkEF9/NJIBEAFZfMJ yVtDltzteLG2W4zstdEJORSf0g0tjgz/D/IXfpeudKYOGDqSdSKecFOVzVFxT8biHR9MNSfZ3j6 eJ9FOGbWGZxVMo7XvtUJvX109nIQtBrx5iau9vNnypIA33xUfQdzVJGKzBtmFdvpgLRSZHrlzIK qLWRmevB84v4ce50SRUOBYvrsWPhDRJph6gPNXl0BshLxT++PyPAHRo5U3VaL6TYrWnhfCttIG5 gGC50+J+K0KYu8B/mXGwFM898Zcns4l1IxNy0EUK5nlOCArv8aEG69EZTwziAzUyWbk2lXekr/B XhXs3EmjMslj5dzpesHtGsZaQ= X-Received: by 2002:a05:690e:1443:b0:667:9bd0:3c0c with SMTP id 956f58d0204a3-667b1d12010mr2722063d50.22.1783578369074; Wed, 08 Jul 2026 23:26:09 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6678779e37fsm3507316d50.5.2026.07.08.23.26.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 23:26:08 -0700 (PDT) From: Thiago Jung Bauermann To: Matthieu Longo Cc: , Luis Machado , Luis Machado , Andrew Burgess , "Yury Khrustalev" , Pedro Alves , "Tom Tromey" Subject: Re: [PATCH v1 01/10] gdb/linux-tdep: change linux_fill_prpsinfo to return bool In-Reply-To: <20260707154900.94542-2-matthieu.longo@arm.com> (Matthieu Longo's message of "Tue, 7 Jul 2026 16:48:51 +0100") References: <20260707154900.94542-1-matthieu.longo@arm.com> <20260707154900.94542-2-matthieu.longo@arm.com> User-Agent: mu4e 1.14.2; emacs 30.2 Date: Thu, 09 Jul 2026 06:26:04 +0000 Message-ID: <87se5s1xxf.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hello Matthieu, Thank you for these patches. Matthieu Longo writes: > Change linux_fill_prpsinfo() to return a boolean instead of an integer, since > it only reports success or failure. > Replace the returned integer values 1 and 0 with true and false respectively. > --- > gdb/linux-tdep.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) In his review of an analogous patch, Simon suggested that this kind of change could be pushed as obvious: https://inbox.sourceware.org/gdb-patches/53a86cae-2927-49ec-83a2-22ff6526c0e6@simark.ca/ I would agree, but I don't know if that's a generally accepted view. In any case: Reviewed-by: Thiago Jung Bauermann -- Thiago (he/him)