From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iV/gHsUph2qAizIAWB0awg (envelope-from ) for ; Thu, 20 Aug 2026 12:22:29 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KtxyAz15; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 78EA91E0A3; Thu, 20 Aug 2026 12:22:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6D6871E033 for ; Thu, 20 Aug 2026 12:22:28 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 679254BAE7F3 for ; Thu, 20 Aug 2026 16:22:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 679254BAE7F3 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KtxyAz15 Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id A31184B9DB54 for ; Thu, 20 Aug 2026 16:22:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A31184B9DB54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A31184B9DB54 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787242921; cv=none; b=I0UVqaROK+L6nMNiP8ZoRkI+ovkP+olnbZ8kJ5iPmRnzyCWAN62nkIxYkAsCGi8YEpJYVXREL+4WeaGcSdOyM+hQcnJ168oFTAB1WMUf44aLpV2c1KiAfzFzjQ2+EzV1dmyvZc0z/3+KpJwPSbv4oElGqKsnanSVtXAfBKPcAfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787242921; c=relaxed/simple; bh=hQ7CTHvo8jYraMliqh1o3/cHksgVF70p7uh5E9OQJqc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=m/EszUcsVw1tTP2uE0VpC+9Y25RwhfMreCWVM3npudmfPzT+32dMzv+JZE/9jZZaICml3FEQQQkUcREhrVGHej6TEIxjfq3z7vjA9fSRZHaJ65DKdzH+inL7ig3Wb8zK8t/DpqZZOqG+hYJawe6H9QVeMCTYP3Tb3vSt3+PwvWs= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KtxyAz15 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A31184B9DB54 Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id x4FQwKI6Ov0ndx5WiwPxn2; Thu, 20 Aug 2026 16:22:00 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id x5WgwpdFHR2Qyx5Whwn2Hd; Thu, 20 Aug 2026 16:21:59 +0000 X-Authority-Analysis: v=2.4 cv=fI053Yae c=1 sm=1 tr=0 ts=6a8729a8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Sv0fKeRqtYgA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=BA0XHXC3zY2IeqKXJw8A:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kN03fLJJhBTpv5/9wvKHGhr2CkoF+ayJFzvlKHH8Zek=; b=KtxyAz15qGUPlmIu42AbVi/1XE VMLDUv+siXBIBurVYoXnvK0iOnZZ7tE/jAX4rQgLKAmQAIzHD3nZ1ospJRFCsxUNbh79m5jfCkKOo GbGzQGXt7rrMEKYepIVBFeYkK; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:48438 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1wx5Wg-00000002ThS-2IGg; Thu, 20 Aug 2026 10:21:58 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: fix crash when pretty printing anonymous struct with base class In-Reply-To: <20260817145907.142300-1-simon.marchi@efficios.com> (Simon Marchi's message of "Mon, 17 Aug 2026 10:59:01 -0400") References: <20260817145907.142300-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Thu, 20 Aug 2026 10:21:57 -0600 Message-ID: <87se48u5i2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1wx5Wg-00000002ThS-2IGg X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:48438 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBpckj8lSCDJMbsFou6fu57ze0nVz6BLZQjoESzG2pshL31pyYPfclROMMvTijICw6SUxqtWpfZWZY32jTX1vr8DVFpthAigB/XSCM8pVNqv/MvEHSzL OmV+xyKoPiKerSad2cAdcxbI0Enf/WG4sfKdDzXhRf9hqltNYN2Sff3vzRwsGO4dUsStbi39yHJXc7hTUcbBpg910OuIWYNpA8c= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> As I was reviewing another patch, I was wondering if we allowed Simon type->name() to be nullptr. The answer is yes, but there are some spots Simon> that don't check for nullptr, when they should. Thanks for looking at this. I sometimes wonder if this is something we ought to fix, like reject nullptr here. But shrug. Simon> - gdb_puts (type->name (), stream); Simon> + gdb_puts (type->safe_name (), stream); It would be nice here if the <...> form were in metadata style. Tom